Skip to content

RxJS 6 support #1568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aalmajanob opened this issue May 29, 2018 · 11 comments
Closed

RxJS 6 support #1568

aalmajanob opened this issue May 29, 2018 · 11 comments

Comments

@aalmajanob
Copy link

Dear Telerik team,

Any ETA on this update within your different Angular componenets?

Installing rxjs-compat@6 is not a valid solution. Of all the Angular components we use at Production, Kendo is always by far the latest to keep up with any Angular upgrade.

Regards,

@tsvetomir
Copy link
Member

There seems to be a bit of misunderstanding on how rxjs-compat actually works. If you take a look at the source code, you'll see that it only contains re-exports. They will be folded during the build process, resulting in an identical output as when using the new RxJS 6.0 entry points.

It's a very clever solution, that does not alter how RxJS works. Any code that does not rely on backwards-compatibility will work in exactly the same way with rxjs-compat or not.

At the same time it allows us to keep updates flowing to Angular 4 and 5 users. It's a trade-off, but we feel it's important not to leave customers stranded.

@aalmajanob
Copy link
Author

Dear tsvetomir,

Thanks for the info, anyway does Telerik plan to make its Angular components RxJS 6 native? If yes, do they have any estimated date?

Regards,

@tsvetomir
Copy link
Member

We plan to drop the requirement for rxjs-compat shortly after Angular 5 reaches end-of-life in April 2019.

The initial plan was for October 2018 when Angular 4 reaches EoL, but the LTS was extended to include all releases.

@aalmajanob
Copy link
Author

Thanks for the fast reply tsvetomir.

Regards,

@Ristaaf
Copy link

Ristaaf commented May 30, 2018

Could be good to know that using rxjs-compat seems to break unit-testing in angular-cli, so we are eagerly awaiting the removal of the dependency in kendo! angular/angular-cli#10485

@tsvetomir
Copy link
Member

@Ristaaf let's give the CLI team a bit more time - this looks like something that must be fixed there.

@aalmajanob
Copy link
Author

Sincerely @Ristaaf, from our experience with Kendo UI, its better to look for any other Real alternative. Thanks we have been replacing the different modules and now we only use Grid´s one :)

Regards,

@shmuel-slate
Copy link

I think I am talking on behalf of all your customers, @tsvetomir, what the problem to have 2 versions?
While you keep some of your customers happy, you are making most of them upset!

@tsvetomir
Copy link
Member

@shmuel-slate the most significant problems are:

  • Users would have to figure out what version (or dist tag) of the components to use based on the Angular version in your project
  • Projects using Angular 4 and 5 would break upon installing the latest versions of the Kendo UI packages. These versions are supported until October 2018 and April 2019 respectively.
  • Users would have to update their projects to Angular 6 to receive updates to the Kendo UI components. The legacy versions would get only critical bug fixes, if any.

At the same time, the only noticeable improvement in user projects would be the omission of rxjs-compat. Please note that rxjs-compat does not include any legacy RxJS code - it only re-exports RxJS 6.x code at different locations.

@oocx
Copy link

oocx commented Apr 12, 2019

Being able to ommit rxjs-compat is important for us, as otherwise our developers could just accidentally use the old apis. We have about 40 developers on our team. Simply removing rxjs-compat is much easier and cheaper than explaining to all of them which parts of rxjs are ok to use and which parts are not. Exposing two different sets of apis for rxjs is confusing and increases training and maintenance costs.

@tsvetomir
Copy link
Member

We'll be getting rid of rxjs-compat in the coming month. We hope to release updated versions of all packages shortly after the support expiration date for Angular 5 - May 1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants