Skip to content

Removing rxjs/rx imports #815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thaoula opened this issue Aug 11, 2017 · 3 comments
Closed

Removing rxjs/rx imports #815

thaoula opened this issue Aug 11, 2017 · 3 comments
Labels

Comments

@thaoula
Copy link

thaoula commented Aug 11, 2017

Hi Guys,

I frequently search our code base for the accidental import rxjs elements using rxjs/Rx.

As you know this statement will load the entire rxjs library.

Are you able to update your components to use specific imports?

Example from the combo box component
import { Observable } from 'rxjs/Observable';
import 'rxjs/add/operator/filter';
import 'rxjs/add/operator/catch';
import 'rxjs/add/operator/do';
import 'rxjs/add/operator/merge';
import 'rxjs/add/operator/map';
import 'rxjs/add/operator/let';
import 'rxjs/add/operator/partition';
import 'rxjs/add/operator/throttleTime';
import 'rxjs/add/operator/distinctUntilChanged';
import { Subject } from 'rxjs/Subject';
import { Subscription } from 'rxjs/Rx';
import { isPresent, isChanged, guid, isDocumentAvailable, getter } from './util';

I came across this when trying to track down issues when using the new build optimiser settings.
angular/angular-cli#7110

Regards,
Tarek

@tsvetomir
Copy link
Member

Thanks for the heads-up, will do.

@tsvetomir
Copy link
Member

Fixed in the dev versions of the Dropdowns, DateInputs and Upload. Will be included in their next official releases.

@siyka-marinova
Copy link

Fix is now available in the latest official packages:
@progress/[email protected]
@progress/[email protected]
@progress/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants