Skip to content

Commit 0516c46

Browse files
committed
Deprecate Versioning APIs previous_* response fields (#669)
_**READ BEFORE MERGING:** All PRs require approval by both Server AND SDK teams before merging! This is why the number of required approvals is "2" and not "1"--two reviewers from the same team is NOT sufficient. If your PR is not approved by someone in BOTH teams, it may be summarily reverted._ <!-- Describe what has changed in this PR --> Deprecating the following fields in favor of API idempotency. - `SetWorkerDeploymentCurrentVersionResponse.previous_deployment_version` - `SetWorkerDeploymentRampingVersionResponse.previous_deployment_version` - `SetWorkerDeploymentRampingVersionResponse.previous_percentage` - `SetWorkerDeploymentManagerResponse.previous_manager_identity` <!-- Tell your future self why have you made these changes --> The fields do not fit well with these idempotent APIs. They will return invalid results when the API is retried by server or client. Users who need this info can use `DescribeWorkerDeployment` before calling this the `Set*` APIs. By passing the `conflict_token` got from the `DescribeWorkerDeployment` call to the Set API they can ensure there is no interfering changes between the two calls. <!-- Are there any breaking changes on binary or code level? --> **Breaking changes** These fields are deprecated and will stop being populated sometime after Versioning GA. <!-- If this breaks the Server, please provide the Server PR to merge right after this PR was merged. --> **Server PR** No server change.
1 parent 0a1205b commit 0516c46

File tree

4 files changed

+41
-13
lines changed

4 files changed

+41
-13
lines changed

temporalproto/openapi/openapiv2.go

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

temporalproto/openapi/openapiv3.go

Lines changed: 1 addition & 1 deletion
Large diffs are not rendered by default.

workflowservice/v1/request_response.pb.go

Lines changed: 38 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)