Skip to content

Commit f474cb6

Browse files
authored
Refinement of comments around namespace capacity (#100)
1 parent d61e29a commit f474cb6

File tree

2 files changed

+17
-12
lines changed

2 files changed

+17
-12
lines changed

.github/workflows/build.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,8 @@ jobs:
1111
check-latest: true
1212
- name: Install Protoc
1313
uses: arduino/setup-protoc@v2
14+
with:
15+
repo-token: ${{ secrets.GITHUB_TOKEN }}
1416
- name: Validate and build go bindings from the proto files
1517
run: make ci-build
1618
env:

temporal/api/cloud/namespace/v1/message.proto

Lines changed: 15 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -95,40 +95,41 @@ message HighAvailabilitySpec {
9595
// temporal:versioning:min_version=v0.10.0
9696
message CapacitySpec {
9797
oneof spec {
98-
// on-demand capacity (dynamic-envelope)
98+
// The on-demand capacity mode configuration.
9999
OnDemand on_demand = 1;
100-
// provisioned capacity
100+
// The provisioned capacity mode configuration.
101101
Provisioned provisioned = 2;
102102
}
103103

104104
message OnDemand {
105105
}
106106

107107
message Provisioned {
108-
// the unit of the provisioned capacity (Temporal Resource Units)
108+
// The units of provisioned capacity in TRU (Temporal Resource Units).
109+
// Each TRU unit assigned to the namespace will entitle it with additional APS limits as specified in the documentation.
109110
double value = 1;
110111
}
111112
}
112113

113114
message Capacity {
114-
115115
oneof current_mode {
116-
// the current capacity is on-demand
116+
// The status of on-demand capacity mode.
117117
OnDemand on_demand = 1;
118-
// the current capacity is provisioned
118+
// The status of provisioned capacity mode.
119119
Provisioned provisioned = 2;
120120
}
121121

122122
message OnDemand {
123123
}
124124

125125
message Provisioned {
126-
// the current unit of the provisioned capacity (Temporal Resource Units)
126+
// The current provisioned capacity for the namespace in Temporal Resource Units.
127+
// Can be different from the requested capacity in latest_request if the request is still in progress.
127128
double current_value = 1;
128129
}
129130

130131
message Request {
131-
// the current state of the capacity request (e.g. in-progress, completed, failed)
132+
// The current state of the capacity request (e.g. in-progress, completed, failed).
132133
State state = 1;
133134
// The date and time when the capacity request was created.
134135
google.protobuf.Timestamp start_time = 2;
@@ -147,7 +148,7 @@ message Capacity {
147148
}
148149
}
149150

150-
// The latest capacity request, if any.
151+
// The latest requested capacity for the namespace, if any.
151152
Request latest_request = 3;
152153
}
153154

@@ -209,6 +210,10 @@ message NamespaceSpec {
209210
repeated string connectivity_rule_ids = 11;
210211

211212
// The capacity configuration for the namespace.
213+
// There are two capacity modes: on-demand and provisioned.
214+
// On-demand capacity mode allows the namespace to scale automatically based on usage.
215+
// Provisioned capacity mode allows the user to specify a fixed amount of capacity (in TRUs) for the namespace.
216+
// Can be changed only when the last capacity request is not in progress.
212217
// temporal:versioning:min_version=v0.10.0
213218
CapacitySpec capacity_spec = 12;
214219

@@ -292,11 +297,9 @@ message Namespace {
292297
map<string, NamespaceRegionStatus> region_status = 12;
293298
// The connectivity rules that are set on this namespace.
294299
repeated temporal.api.cloud.connectivityrule.v1.ConnectivityRule connectivity_rules = 14;
295-
296300
// The tags for the namespace.
297301
map<string, string> tags = 15;
298-
299-
// The capacity of the namespace.
302+
// The status of namespace's capacity, if any.
300303
Capacity capacity = 16;
301304
}
302305

0 commit comments

Comments
 (0)