Skip to content

Commit 17ecf2d

Browse files
authored
Remove GHA var interpolation (#226)
WISOTT
1 parent 565ac79 commit 17ecf2d

File tree

2 files changed

+4
-8
lines changed

2 files changed

+4
-8
lines changed

.github/workflows/all-docker-images.yml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -109,7 +109,6 @@ jobs:
109109
uses: ./.github/workflows/docker-images.yml
110110
secrets: inherit
111111
with:
112-
build-command: build-cli-image
113112
push-command: build-push-cli-image
114113
do-push: ${{ inputs.do-push }}
115114
as-latest: ${{ inputs.as-latest }}

.github/workflows/docker-images.yml

Lines changed: 4 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,6 @@ name: Build docker images
22
on:
33
workflow_call:
44
inputs:
5-
build-command:
6-
description: Build command to run (e.g., 'build-worker-image' or 'build-cli-image')
7-
type: string
8-
default: "build-worker-image"
95
push-command:
106
description: Push command to run (e.g., 'build-push-worker-image' or 'build-push-cli-image')
117
type: string
@@ -90,8 +86,9 @@ jobs:
9086
TAG_LATEST_ARGS: ${{ inputs.as-latest && '--tag-as-latest' || ''}}
9187
LANG_ARGS: ${{ inputs.lang && format('--language {0}', inputs.lang) || '' }}
9288
VERSION_ARGS: ${{ inputs.sdk-version && format('--version {0}', inputs.sdk-version) || '' }}
89+
PUSH_COMMAND: ${{ inputs.push-command }}
9390
run: |
94-
go run ./cmd/dev ${{ inputs.push-command }} \
91+
go run ./cmd/dev "$PUSH_COMMAND" \
9592
--platform linux/amd64,linux/arm64 \
9693
--repo-prefix temporaliotest \
9794
$LANG_ARGS \
@@ -101,6 +98,6 @@ jobs:
10198
10299
- name: 🐳 Docker Hub image tag
103100
env:
104-
LANG: ${{ inputs.lang }}
101+
LANG: ${{ inputs.lang || 'CLI' }}
105102
run: |
106-
echo "::notice title=🐳 Docker Hub image published for ${{ inputs.lang || 'CLI' }}::Check temporaliotest/omes tags"
103+
echo "::notice title=🐳 Docker Hub image published for $LANG::Check temporaliotest/omes tags"

0 commit comments

Comments
 (0)