Fix cloud CI run and minor doc fix (#339)

Fixes #331
Fixes #333

Author: cretz

.github/workflows/ci.yml

@@ -98,10 +98,10 @@ jobs:
         # Only supported in non-fork runs, since secrets are not available in forks
         if: ${{ matrix.cloudTestTarget && (github.event.pull_request.head.repo.full_name == '' || github.event.pull_request.head.repo.full_name == 'temporalio/sdk-dotnet') }}
         env:
-          TEMPORAL_CLIENT_TARGET_HOST: ${{ vars.TEMPORAL_CLIENT_NAMESPACE }}.tmprl.cloud:7233
-          TEMPORAL_CLIENT_NAMESPACE: ${{ vars.TEMPORAL_CLIENT_NAMESPACE }}
-          TEMPORAL_CLIENT_CERT: ${{ secrets.TEMPORAL_CLIENT_CERT }}
-          TEMPORAL_CLIENT_KEY: ${{ secrets.TEMPORAL_CLIENT_KEY }}
+          TEMPORAL_TEST_CLIENT_TARGET_HOST: ${{ vars.TEMPORAL_CLIENT_NAMESPACE }}.tmprl.cloud:7233
+          TEMPORAL_TEST_CLIENT_NAMESPACE: ${{ vars.TEMPORAL_CLIENT_NAMESPACE }}
+          TEMPORAL_TEST_CLIENT_CERT: ${{ secrets.TEMPORAL_CLIENT_CERT }}
+          TEMPORAL_TEST_CLIENT_KEY: ${{ secrets.TEMPORAL_CLIENT_KEY }}
         run: dotnet run --project tests/Temporalio.Tests -- -verbose -method "*.ExecuteWorkflowAsync_Simple_Succeeds"
 
       - name: Test cloud operations client

src/Temporalio/Client/WorkflowCancelOptions.cs

@@ -8,7 +8,7 @@ namespace Temporalio.Client
     public class WorkflowCancelOptions : ICloneable
     {
         /// <summary>
-        /// Gets or sets RPC options for starting the workflow.
+        /// Gets or sets RPC options for cancelling the workflow.
         /// </summary>
         public RpcOptions? Rpc { get; set; }
 

src/Temporalio/Client/WorkflowDescribeOptions.cs

@@ -8,7 +8,7 @@ namespace Temporalio.Client
     public class WorkflowDescribeOptions : ICloneable
     {
         /// <summary>
-        /// Gets or sets RPC options for starting the workflow.
+        /// Gets or sets RPC options for describing the workflow.
         /// </summary>
         public RpcOptions? Rpc { get; set; }
 

src/Temporalio/Client/WorkflowHistoryEventFetchOptions.cs

@@ -26,7 +26,7 @@ public class WorkflowHistoryEventFetchOptions : ICloneable
         public bool SkipArchival { get; set; }
 
         /// <summary>
-        /// Gets or sets RPC options for starting the workflow.
+        /// Gets or sets RPC options for fetching history event pages.
         /// </summary>
         public RpcOptions? Rpc { get; set; }
 

src/Temporalio/Client/WorkflowHistoryFetchOptions.cs

@@ -21,7 +21,7 @@ public class WorkflowHistoryFetchOptions : ICloneable
         public bool SkipArchival { get; set; }
 
         /// <summary>
-        /// Gets or sets RPC options for starting the workflow.
+        /// Gets or sets RPC options for fetching history.
         /// </summary>
         public RpcOptions? Rpc { get; set; }
 

src/Temporalio/Client/WorkflowListOptions.cs

@@ -9,7 +9,7 @@ namespace Temporalio.Client
     public class WorkflowListOptions : ICloneable
     {
         /// <summary>
-        /// Gets or sets RPC options for starting the workflow.
+        /// Gets or sets RPC options for listing workflows.
         /// </summary>
         public RpcOptions? Rpc { get; set; }
 

src/Temporalio/Client/WorkflowQueryOptions.cs

@@ -15,7 +15,7 @@ public class WorkflowQueryOptions : ICloneable
         public QueryRejectCondition? RejectCondition { get; set; }
 
         /// <summary>
-        /// Gets or sets RPC options for starting the workflow.
+        /// Gets or sets RPC options for querying the workflow.
         /// </summary>
         public RpcOptions? Rpc { get; set; }
 

src/Temporalio/Client/WorkflowSignalOptions.cs

@@ -9,7 +9,7 @@ namespace Temporalio.Client
     public class WorkflowSignalOptions : ICloneable
     {
         /// <summary>
-        /// Gets or sets RPC options for starting the workflow.
+        /// Gets or sets RPC options for signalling the workflow.
         /// </summary>
         public RpcOptions? Rpc { get; set; }
 

src/Temporalio/Client/WorkflowTerminateOptions.cs

@@ -14,7 +14,7 @@ public class WorkflowTerminateOptions : ICloneable
         public IReadOnlyCollection<object?>? Details { get; set; }
 
         /// <summary>
-        /// Gets or sets RPC options for starting the workflow.
+        /// Gets or sets RPC options for terminating the workflow.
         /// </summary>
         public RpcOptions? Rpc { get; set; }
 

src/Temporalio/Client/WorkflowUpdateOptions.cs

@@ -29,7 +29,7 @@ public WorkflowUpdateOptions()
         public string? Id { get; set; }
 
         /// <summary>
-        /// Gets or sets RPC options for starting the workflow.
+        /// Gets or sets RPC options for update RPC calls.
         /// </summary>
         public RpcOptions? Rpc { get; set; }