Fix improper casts during clone (#284)

Fixes #274

Author: cretz

src/Temporalio/Client/Schedules/ScheduleListOptions.cs

@@ -19,7 +19,7 @@ public class ScheduleListOptions : ICloneable
         /// <returns>A shallow copy of these options and any transitive options fields.</returns>
         public virtual object Clone()
         {
-            var copy = (WorkflowListOptions)MemberwiseClone();
+            var copy = (ScheduleListOptions)MemberwiseClone();
             if (Rpc != null)
             {
                 copy.Rpc = (RpcOptions)Rpc.Clone();

src/Temporalio/Client/Schedules/ScheduleOptions.cs

@@ -42,7 +42,7 @@ public class ScheduleOptions : ICloneable
         /// <returns>A shallow copy of these options and any transitive options fields.</returns>
         public virtual object Clone()
         {
-            var copy = (WorkflowOptions)MemberwiseClone();
+            var copy = (ScheduleOptions)MemberwiseClone();
             if (Rpc != null)
             {
                 copy.Rpc = (RpcOptions)Rpc.Clone();

src/Temporalio/Client/Schedules/ScheduleTriggerOptions.cs

@@ -23,7 +23,7 @@ public class ScheduleTriggerOptions
         /// <returns>A shallow copy of these options and any transitive options fields.</returns>
         public virtual object Clone()
         {
-            var copy = (WorkflowOptions)MemberwiseClone();
+            var copy = (ScheduleTriggerOptions)MemberwiseClone();
             if (Rpc != null)
             {
                 copy.Rpc = (RpcOptions)Rpc.Clone();

src/Temporalio/Client/WorkflowCancelOptions.cs

@@ -18,7 +18,7 @@ public class WorkflowCancelOptions : ICloneable
         /// <returns>A shallow copy of these options and any transitive options fields.</returns>
         public virtual object Clone()
         {
-            var copy = (WorkflowSignalOptions)MemberwiseClone();
+            var copy = (WorkflowCancelOptions)MemberwiseClone();
             if (Rpc != null)
             {
                 copy.Rpc = (RpcOptions)Rpc.Clone();

src/Temporalio/Client/WorkflowHistoryFetchOptions.cs

@@ -31,7 +31,7 @@ public class WorkflowHistoryFetchOptions : ICloneable
         /// <returns>A shallow copy of these options and any transitive options fields.</returns>
         public virtual object Clone()
         {
-            var copy = (WorkflowHistoryEventFetchOptions)MemberwiseClone();
+            var copy = (WorkflowHistoryFetchOptions)MemberwiseClone();
             if (Rpc != null)
             {
                 copy.Rpc = (RpcOptions)Rpc.Clone();

tests/Temporalio.Tests/GeneralTests.cs

@@ -0,0 +1,39 @@
+namespace Temporalio.Tests;
+
+using System.Reflection;
+using Xunit;
+using Xunit.Abstractions;
+
+public class GeneralTests : TestBase
+{
+    public GeneralTests(ITestOutputHelper output)
+        : base(output)
+    {
+    }
+
+    [Fact]
+    public void CloneableTypes_InstantiateAndClone_Succeeds()
+    {
+        // Walk Temporal assemblies finding all classes that are cloneable
+        var types = AppDomain.CurrentDomain.GetAssemblies().SelectMany(a => a.GetTypes().Where(t =>
+            t.IsClass &&
+            t.Namespace is { } ns &&
+            ns.StartsWith("Temporalio.") &&
+            !ns.StartsWith("Temporalio.Api.") &&
+            !ns.StartsWith("Temporalio.Bridge.") &&
+            t.GetMethod("Clone", BindingFlags.Public | BindingFlags.Instance) != null));
+        // Ensure at least one we know of is there
+        Assert.Contains(typeof(Temporalio.Client.Schedules.ScheduleListOptions), types);
+        foreach (var type in types)
+        {
+            // Instantiate and attempt clone
+            var noParamConstructor = type.GetConstructors().
+                First(c => c.GetParameters().All(p => p.IsOptional));
+            var instance = noParamConstructor.Invoke(noParamConstructor.GetParameters()
+                .Select(p => p.DefaultValue)
+                .ToArray());
+            var clone = type.GetMethod("Clone")!.Invoke(instance, null);
+            Assert.IsType(type, clone);
+        }
+    }
+}