Skip to content

Commit 16d9d2d

Browse files
committed
refactor: update psalm baseline
1 parent 33a3201 commit 16d9d2d

File tree

2 files changed

+9
-57
lines changed

2 files changed

+9
-57
lines changed

psalm-baseline.xml

Lines changed: 7 additions & 55 deletions
Original file line numberDiff line numberDiff line change
@@ -1019,28 +1019,16 @@
10191019
</UndefinedInterfaceMethod>
10201020
</file>
10211021
<file src="src/Internal/Transport/CompletableResult.php">
1022-
<MoreSpecificImplementedParamType>
1023-
<code><![CDATA[$onFulfilled]]></code>
1024-
<code><![CDATA[$onRejected]]></code>
1025-
</MoreSpecificImplementedParamType>
10261022
<PossiblyNullArgument>
10271023
<code><![CDATA[$this->wrapContext($onFulfilledOrRejected)]]></code>
10281024
<code><![CDATA[$this->wrapContext($onRejected)]]></code>
10291025
</PossiblyNullArgument>
1030-
<TooManyTemplateParams>
1031-
<code><![CDATA[PromiseInterface<T>]]></code>
1032-
</TooManyTemplateParams>
10331026
<UndefinedInterfaceMethod>
10341027
<code><![CDATA[cancel]]></code>
10351028
<code><![CDATA[catch]]></code>
10361029
<code><![CDATA[finally]]></code>
10371030
</UndefinedInterfaceMethod>
10381031
</file>
1039-
<file src="src/Internal/Transport/CompletableResultInterface.php">
1040-
<TooManyTemplateParams>
1041-
<code><![CDATA[PromiseInterface]]></code>
1042-
</TooManyTemplateParams>
1043-
</file>
10441032
<file src="src/Internal/Transport/Router/DestroyWorkflow.php">
10451033
<UndefinedInterfaceMethod>
10461034
<code><![CDATA[pull]]></code>
@@ -1176,6 +1164,10 @@
11761164
</PropertyNotSetInConstructor>
11771165
</file>
11781166
<file src="src/Internal/Workflow/Process/Scope.php">
1167+
<InvalidArgument>
1168+
<code><![CDATA[$onFulfilled]]></code>
1169+
<code><![CDATA[$onRejected]]></code>
1170+
</InvalidArgument>
11791171
<PropertyNotSetInConstructor>
11801172
<code><![CDATA[$coroutine]]></code>
11811173
</PropertyNotSetInConstructor>
@@ -1216,6 +1208,9 @@
12161208
<code><![CDATA[$type]]></code>
12171209
<code><![CDATA[$type]]></code>
12181210
</ArgumentTypeCoercion>
1211+
<DocblockTypeContradiction>
1212+
<code><![CDATA[\is_iterable($reason)]]></code>
1213+
</DocblockTypeContradiction>
12191214
<InaccessibleProperty>
12201215
<code><![CDATA[$this->input->info->typedSearchAttributes]]></code>
12211216
</InaccessibleProperty>
@@ -1240,13 +1235,6 @@
12401235
<code><![CDATA[object]]></code>
12411236
<code><![CDATA[object]]></code>
12421237
</InvalidReturnType>
1243-
<MissingClosureParamType>
1244-
<code><![CDATA[$reason]]></code>
1245-
<code><![CDATA[$result]]></code>
1246-
</MissingClosureParamType>
1247-
<MissingClosureReturnType>
1248-
<code><![CDATA[function ($result) use ($conditionGroupId) {]]></code>
1249-
</MissingClosureReturnType>
12501238
<MissingImmutableAnnotation>
12511239
<code><![CDATA[WorkflowContext]]></code>
12521240
</MissingImmutableAnnotation>
@@ -1268,11 +1256,6 @@
12681256
<TooManyArguments>
12691257
<code><![CDATA[$reduce($c, $value, $i++, $total)]]></code>
12701258
</TooManyArguments>
1271-
<TooManyTemplateParams>
1272-
<code><![CDATA[PromiseInterface<T>]]></code>
1273-
<code><![CDATA[PromiseInterface<never>]]></code>
1274-
<code><![CDATA[iterable<PromiseInterface<T>|T>]]></code>
1275-
</TooManyTemplateParams>
12761259
</file>
12771260
<file src="src/Worker/ActivityInvocationCache/ActivityInvocationResult.php">
12781261
<MissingReturnType>
@@ -1517,22 +1500,6 @@
15171500
<code><![CDATA[ScopedContextInterface]]></code>
15181501
<code><![CDATA[T]]></code>
15191502
</InvalidReturnType>
1520-
<TooManyTemplateParams>
1521-
<code><![CDATA[PromiseInterface<TReturn>]]></code>
1522-
<code><![CDATA[PromiseInterface<UuidInterface>]]></code>
1523-
<code><![CDATA[PromiseInterface<UuidInterface>]]></code>
1524-
<code><![CDATA[PromiseInterface<UuidInterface>]]></code>
1525-
<code><![CDATA[PromiseInterface<bool>]]></code>
1526-
<code><![CDATA[PromiseInterface<int>]]></code>
1527-
<code><![CDATA[PromiseInterface<mixed>]]></code>
1528-
<code><![CDATA[PromiseInterface<mixed>]]></code>
1529-
<code><![CDATA[PromiseInterface<null>]]></code>
1530-
</TooManyTemplateParams>
1531-
</file>
1532-
<file src="src/Workflow/CancellationScopeInterface.php">
1533-
<TooManyTemplateParams>
1534-
<code><![CDATA[PromiseInterface]]></code>
1535-
</TooManyTemplateParams>
15361503
</file>
15371504
<file src="src/Workflow/ChildWorkflowOptions.php">
15381505
<PossiblyNullReference>
@@ -1544,11 +1511,6 @@
15441511
<code><![CDATA[$returnType]]></code>
15451512
</MissingParamType>
15461513
</file>
1547-
<file src="src/Workflow/Mutex.php">
1548-
<TooManyTemplateParams>
1549-
<code><![CDATA[PromiseInterface<self>]]></code>
1550-
</TooManyTemplateParams>
1551-
</file>
15521514
<file src="src/Workflow/QueryMethod.php">
15531515
<DeprecatedClass>
15541516
<code><![CDATA[NamedArgumentConstructor]]></code>
@@ -1579,16 +1541,6 @@
15791541
<code><![CDATA[NamedArgumentConstructor]]></code>
15801542
</DeprecatedClass>
15811543
</file>
1582-
<file src="src/Workflow/WorkflowContextInterface.php">
1583-
<TooManyTemplateParams>
1584-
<code><![CDATA[PromiseInterface<TReturn>]]></code>
1585-
<code><![CDATA[PromiseInterface<UuidInterface>]]></code>
1586-
<code><![CDATA[PromiseInterface<UuidInterface>]]></code>
1587-
<code><![CDATA[PromiseInterface<UuidInterface>]]></code>
1588-
<code><![CDATA[PromiseInterface<bool>]]></code>
1589-
<code><![CDATA[PromiseInterface<mixed>]]></code>
1590-
</TooManyTemplateParams>
1591-
</file>
15921544
<file src="src/Workflow/WorkflowInterface.php">
15931545
<DeprecatedClass>
15941546
<code><![CDATA[NamedArgumentConstructor]]></code>

src/Internal/Workflow/WorkflowContext.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -753,11 +753,11 @@ protected function awaitRequest(callable|Mutex|PromiseInterface ...$conditions):
753753
}
754754

755755
return Promise::any($result)->then(
756-
function ($result) use ($conditionGroupId) {
756+
function (mixed $result) use ($conditionGroupId) {
757757
$this->resolveConditionGroup($conditionGroupId);
758758
return $result;
759759
},
760-
function ($reason) use ($conditionGroupId): void {
760+
function (\Throwable $reason) use ($conditionGroupId): void {
761761
$this->rejectConditionGroup($conditionGroupId);
762762
// Throw the first reason
763763
// It need to avoid memory leak when the related workflow is destroyed

0 commit comments

Comments
 (0)