chore: rename retryPolicy to retryOptions

Author: roxblnfk

src/Internal/Marshaller/Type/ArrayType.php

@@ -63,6 +63,10 @@ public static function makeRule(\ReflectionProperty $property): ?MarshallingRule
      */
     public function parse($value, $current): array
     {
+        if ($value === null) {
+            return [];
+        }
+
         if (!\is_array($value)) {
             throw new \InvalidArgumentException(\sprintf(self::ERROR_INVALID_TYPE, \get_debug_type($value)));
         }

src/Workflow/WorkflowInfo.php

@@ -148,7 +148,7 @@ final class WorkflowInfo
      * @since SDK 2.16.0
      */
     #[Marshal(name: 'RetryPolicy')]
-    public ?RetryOptions $retryPolicy = null;
+    public ?RetryOptions $retryOptions = null;
 
     /**
      * WorkflowInfo constructor.

tests/Acceptance/Extra/Activity/ActivityInfoTest.php

@@ -19,7 +19,7 @@ class ActivityInfoTest extends TestCase
 {
     #[Test]
     public static function retryPolicy(
-        #[Stub('Extra_Activity_ActivityInfo', args: [TestWorkflow::ARG_RETRY_POLICY])]
+        #[Stub('Extra_Activity_ActivityInfo', args: [TestWorkflow::ARG_RETRY_OPTIONS])]
         WorkflowStubInterface $stub,
     ): void {
         self::markTestSkipped('See https://github.com/temporalio/sdk-php/issues/602');
@@ -39,17 +39,17 @@ public static function retryPolicy(
 #[WorkflowInterface]
 class TestWorkflow
 {
-    public const ARG_RETRY_POLICY = 'retryPolicy';
+    public const ARG_RETRY_OPTIONS = 'retryPolicy';
 
     #[WorkflowMethod(name: "Extra_Activity_ActivityInfo")]
     public function handle(string $arg)
     {
         return yield match ($arg) {
-            self::ARG_RETRY_POLICY => $this->getRetryPolicy(),
+            self::ARG_RETRY_OPTIONS => $this->getRetryOptions(),
         };
     }
 
-    private function getRetryPolicy(): PromiseInterface
+    private function getRetryOptions(): PromiseInterface
     {
         return Workflow::newActivityStub(
             TestActivity::class,
@@ -63,16 +63,16 @@ private function getRetryPolicy(): PromiseInterface
                 )
                 ->withScheduleToCloseTimeout(10),
         )
-            ->retryPolicy();
+            ->retryOptions();
     }
 }
 
 #[Activity\ActivityInterface(prefix: 'Extra_Activity_ActivityInfo.')]
 class TestActivity
 {
     #[Activity\ActivityMethod]
-    public function retryPolicy()
+    public function retryOptions()
     {
-        return Activity::getInfo()->retryPolicy;
+        return Activity::getInfo()->retryOptions;
     }
 }

tests/Acceptance/Extra/Workflow/WorkflowInfoTest.php

@@ -28,8 +28,8 @@ public static function rootWorkflowExecution(
     }
 
     #[Test]
-    public static function retryPolicy(
-        #[Stub('Extra_Workflow_WorkflowInfo', args: [MainWorkflow::ARG_RETRY_POLICY], retryOptions: new RetryOptions(
+    public static function retryOptions(
+        #[Stub('Extra_Workflow_WorkflowInfo', args: [MainWorkflow::ARG_RETRY_OPTIONS], retryOptions: new RetryOptions(
             backoffCoefficient: 3.0,
             maximumInterval: '2 minutes',
             maximumAttempts: 10,
@@ -50,15 +50,15 @@ public static function retryPolicy(
 #[WorkflowInterface]
 class MainWorkflow
 {
-    public const ARG_RETRY_POLICY = 'retryPolicy';
+    public const ARG_RETRY_OPTIONS = 'retryPolicy';
     public const ARG_ROOT_EXECUTION = 'rootExecution';
 
     #[WorkflowMethod('Extra_Workflow_WorkflowInfo')]
     public function run($arg)
     {
         return yield match ($arg) {
             self::ARG_ROOT_EXECUTION => Workflow::newChildWorkflowStub(ChildWorkflow::class)->run(),
-            self::ARG_RETRY_POLICY => Workflow::getCurrentContext()->getInfo()->retryPolicy,
+            self::ARG_RETRY_OPTIONS => Workflow::getCurrentContext()->getInfo()->retryOptions,
         };
     }
 }

tests/Unit/DTO/Type/ArrayType/ArrayTestCase.php

@@ -76,23 +76,11 @@ public function testUnmarshalling(): void
 
     public function testSetNullToNotNullable(): void
     {
-        try {
-            $this->unmarshal([
-                'foo' => null,
-            ], new ArrayDto());
+        $dto = $this->unmarshal([
+            'foo' => null,
+        ], new ArrayDto());
 
-            $this->fail('Null value should not be allowed.');
-        } catch (\Throwable $e) {
-            $this->assertStringContainsString(
-                '`foo`',
-                $e->getMessage(),
-            );
-            $this->assertInstanceOf(\InvalidArgumentException::class, $e->getPrevious());
-            $this->assertStringContainsString(
-                'Passed value must be a type of array, but null given',
-                $e->getPrevious()->getMessage(),
-            );
-        }
+        self::assertSame([], $dto->foo);
     }
 
     protected function getTypeMatchers(): array

tests/Unit/DTO/WorkflowInfoTestCase.php

@@ -51,6 +51,7 @@ public function testMarshalling(): void
             'Priority' => [
                 'priority_key' => 0,
             ],
+            'RetryPolicy' => null,
         ];
 
         $this->assertSame($expected, $this->marshal($dto));