Minor fixes

Author: cretz

.github/workflows/ci.yml

@@ -52,6 +52,11 @@ jobs:
         uses: deadsnakes/[email protected]
         with:
           python-version: ${{ matrix.python }}
+      - uses: arduino/setup-protoc@v3
+        with:
+          # TODO(cretz): Can upgrade proto when https://github.com/arduino/setup-protoc/issues/99 fixed
+          version: "23.x"
+          repo-token: ${{ secrets.GITHUB_TOKEN }}
       # Using fixed Poetry version until
       # https://github.com/python-poetry/poetry/issues/7611 and
       # https://github.com/python-poetry/poetry/pull/7694 are fixed

README.md

@@ -1329,6 +1329,7 @@ To build the SDK from source for use as a dependency, the following prerequisite
 * [Python](https://www.python.org/) >= 3.8
   * Make sure the latest version of `pip` is in use
 * [Rust](https://www.rust-lang.org/)
+* [Protobuf Compiler](https://protobuf.dev/)
 * [poetry](https://github.com/python-poetry/poetry) (e.g. `python -m pip install poetry`)
 * [poe](https://github.com/nat-n/poethepoet) (e.g. `python -m pip install poethepoet`)
 

pyproject.toml

@@ -123,6 +123,7 @@ environment = { PATH = "$PATH:$HOME/.cargo/bin", CARGO_NET_GIT_FETCH_WITH_CLI =
 [tool.isort]
 profile = "black"
 skip_gitignore = true
+extend_skip = ["./temporalio/bridge/sdk-core", "./temporalio/bridge/target"]
 
 [tool.mypy]
 ignore_missing_imports = true

tests/test_converter.py

@@ -261,10 +261,13 @@ class MyTypedDictNotTotal(TypedDict, total=False):
     bar: MyDataClass
 
 
-class MyPydanticClass(pydantic.BaseModel):
-    foo: str
-    bar: List[MyPydanticClass]
-    baz: Optional[UUID] = None
+# TODO(cretz): Fix when https://github.com/pydantic/pydantic/pull/9612 tagged
+if sys.version_info <= (3, 12, 3):
+
+    class MyPydanticClass(pydantic.BaseModel):
+        foo: str
+        bar: List[MyPydanticClass]
+        baz: Optional[UUID] = None
 
 
 def test_json_type_hints():
@@ -401,14 +404,16 @@ def fail(hint: Any, value: Any) -> None:
         ok(tuple[int, str], (1, "2"))
 
     # Pydantic
-    ok(
-        MyPydanticClass,
-        MyPydanticClass(
-            foo="foo", bar=[MyPydanticClass(foo="baz", bar=[])], baz=uuid4()
-        ),
-    )
-    ok(List[MyPydanticClass], [MyPydanticClass(foo="foo", bar=[])])
-    fail(List[MyPydanticClass], [MyPydanticClass(foo="foo", bar=[]), 5])
+    # TODO(cretz): Fix when https://github.com/pydantic/pydantic/pull/9612 tagged
+    if sys.version_info <= (3, 12, 3):
+        ok(
+            MyPydanticClass,
+            MyPydanticClass(
+                foo="foo", bar=[MyPydanticClass(foo="baz", bar=[])], baz=uuid4()
+            ),
+        )
+        ok(List[MyPydanticClass], [MyPydanticClass(foo="foo", bar=[])])
+        fail(List[MyPydanticClass], [MyPydanticClass(foo="foo", bar=[]), 5])
 
 
 # This is an example of appending the stack to every Temporal failure error