Fix type errors

Author: Sushisource

temporalio/lib/temporalio/worker/workflow_replayer.rb

@@ -24,7 +24,6 @@ class WorkflowReplayer
         :data_converter,
         :workflow_executor,
         :interceptors,
-        :build_id,
         :identity,
         :logger,
         :illegal_workflow_calls,
@@ -51,9 +50,6 @@ class Options; end # rubocop:disable Lint/EmptyClass
       # @param workflow_executor [WorkflowExecutor] Workflow executor that workflow tasks run within. This must be a
       #   {WorkflowExecutor::ThreadPool} currently.
       # @param interceptors [Array<Interceptor::Workflow>] Workflow interceptors.
-      # @param build_id [String] Unique identifier for the current runtime. This is best set as a unique value
-      #   representing all code and should change only when code does. This can be something like a git commit hash. If
-      #   unset, default is hash of known Ruby code.
       # @param identity [String, nil] Override the identity for this replater.
       # @param logger [Logger] Logger to use. Defaults to stdout with warn level. Callers setting this logger are
       #   responsible for closing it.
@@ -87,7 +83,6 @@ def initialize(
         data_converter: Converters::DataConverter.default,
         workflow_executor: WorkflowExecutor::ThreadPool.default,
         interceptors: [],
-        build_id: Worker.default_build_id,
         identity: nil,
         logger: Logger.new($stdout, level: Logger::WARN),
         illegal_workflow_calls: Worker.default_illegal_workflow_calls,
@@ -105,7 +100,6 @@ def initialize(
           data_converter:,
           workflow_executor:,
           interceptors:,
-          build_id:,
           identity:,
           logger:,
           illegal_workflow_calls:,
@@ -116,7 +110,9 @@ def initialize(
           runtime:
         ).freeze
         # Preload definitions and other settings
-        @workflow_definitions = Internal::Worker::WorkflowWorker.workflow_definitions(workflows, false)
+        @workflow_definitions = Internal::Worker::WorkflowWorker.workflow_definitions(
+          workflows, should_enforce_versioning_behavior: false
+        )
         @nondeterminism_as_workflow_fail, @nondeterminism_as_workflow_fail_for_types =
           Internal::Worker::WorkflowWorker.bridge_workflow_failure_exception_type_options(
             workflow_failure_exception_types:, workflow_definitions: @workflow_definitions
@@ -207,7 +203,6 @@ def initialize(
               tuner: Tuner.create_fixed(
                 workflow_slots: 2, activity_slots: 1, local_activity_slots: 1
               )._to_bridge_options,
-              build_id: options.build_id,
               identity_override: options.identity,
               max_cached_workflows: 2,
               max_concurrent_workflow_task_polls: 1,
@@ -220,7 +215,6 @@ def initialize(
               max_worker_activities_per_second: nil,
               max_task_queue_activities_per_second: nil,
               graceful_shutdown_period: 0.0,
-              use_worker_versioning: false,
               nondeterminism_as_workflow_fail:,
               nondeterminism_as_workflow_fail_for_types:,
               deployment_options: nil

temporalio/sig/temporalio/internal/bridge/worker.rbs

@@ -8,7 +8,6 @@ module Temporalio
           attr_accessor namespace: String
           attr_accessor task_queue: String
           attr_accessor tuner: TunerOptions
-          attr_accessor build_id: String
           attr_accessor identity_override: String?
           attr_accessor max_cached_workflows: Integer
           attr_accessor max_concurrent_workflow_task_polls: Integer
@@ -21,18 +20,16 @@ module Temporalio
           attr_accessor max_worker_activities_per_second: Float?
           attr_accessor max_task_queue_activities_per_second: Float?
           attr_accessor graceful_shutdown_period: Float
-          attr_accessor use_worker_versioning: bool
           attr_accessor nondeterminism_as_workflow_fail: bool
           attr_accessor nondeterminism_as_workflow_fail_for_types: Array[String]
           attr_accessor deployment_options: DeploymentOptions?
-    
+
           def initialize: (
             activity: bool,
             workflow: bool,
             namespace: String,
             task_queue: String,
             tuner: TunerOptions,
-            build_id: String,
             identity_override: String?,
             max_cached_workflows: Integer,
             max_concurrent_workflow_task_polls: Integer,
@@ -45,7 +42,6 @@ module Temporalio
             max_worker_activities_per_second: Float?,
             max_task_queue_activities_per_second: Float?,
             graceful_shutdown_period: Float,
-            use_worker_versioning: bool,
             nondeterminism_as_workflow_fail: bool,
             nondeterminism_as_workflow_fail_for_types: Array[String],
             deployment_options: DeploymentOptions?
@@ -154,4 +150,4 @@ module Temporalio
       end
     end
   end
-end
+end

temporalio/sig/temporalio/internal/worker/workflow_worker.rbs

@@ -4,7 +4,7 @@ module Temporalio
       class WorkflowWorker
         def self.workflow_definitions: (
           Array[singleton(Workflow::Definition) | Workflow::Definition::Info] workflows,
-          bool should_enforce_versioning_behavior
+          should_enforce_versioning_behavior: bool
         ) -> Hash[String?, Workflow::Definition::Info]
 
         def self.bridge_workflow_failure_exception_type_options: (
@@ -93,4 +93,4 @@ module Temporalio
       end
     end
   end
-end
+end

temporalio/sig/temporalio/worker/workflow_replayer.rbs

@@ -8,7 +8,6 @@ module Temporalio
         attr_reader data_converter: Converters::DataConverter
         attr_reader workflow_executor: Worker::WorkflowExecutor
         attr_reader interceptors: Array[Interceptor::Workflow]
-        attr_reader build_id: String
         attr_reader identity: String?
         attr_reader logger: Logger
         attr_reader illegal_workflow_calls: Hash[String, :all | Array[Symbol]]
@@ -17,15 +16,14 @@ module Temporalio
         attr_reader unsafe_workflow_io_enabled: bool
         attr_reader debug_mode: bool
         attr_reader runtime: Runtime
-  
+
         def initialize: (
           workflows: Array[singleton(Workflow::Definition) | Workflow::Definition::Info],
           namespace: String,
           task_queue: String,
           data_converter: Converters::DataConverter,
           workflow_executor: Worker::WorkflowExecutor,
           interceptors: Array[Interceptor::Workflow],
-          build_id: String,
           identity: String?,
           logger: Logger,
           illegal_workflow_calls: Hash[String, :all | Array[Symbol]],
@@ -46,7 +44,6 @@ module Temporalio
         ?data_converter: Converters::DataConverter,
         ?workflow_executor: Worker::WorkflowExecutor,
         ?interceptors: Array[Interceptor::Workflow],
-        ?build_id: String,
         ?identity: String?,
         ?logger: Logger,
         ?illegal_workflow_calls: Hash[String, :all | Array[Symbol]],
@@ -96,4 +93,4 @@ module Temporalio
       end
     end
   end
-end
+end

temporalio/test/worker_workflow_versioning_test.rb

@@ -459,7 +459,7 @@ def test_default_build_id
     worker = Temporalio::Worker.new(
       client: env.client,
       task_queue: "tq-#{SecureRandom.uuid}",
-      workflows: [NoVersioningAnnotationWorkflow],
+      workflows: [NoVersioningAnnotationWorkflow]
     )
     build_id = Temporalio::Worker.default_build_id