Skip to content

Commit 888864f

Browse files
committed
Fix naming error
1 parent 223b3ac commit 888864f

File tree

3 files changed

+16
-16
lines changed

3 files changed

+16
-16
lines changed

temporalio/lib/temporalio/priority.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ module Temporalio
66
Priority = Data.define(
77
:priority_key,
88
:fairness_key,
9-
:weight
9+
:fairness_weight
1010
)
1111

1212
# Priority contains metadata that controls relative ordering of task processing when tasks are
@@ -44,13 +44,13 @@ module Temporalio
4444
#
4545
# Fairness keys are limited to 64 bytes.
4646
#
47-
# @!attribute weight
47+
# @!attribute fairness_weight
4848
# @return [Float, nil] Weight for a task can come from multiple sources for
4949
# flexibility. From highest to lowest precedence:
5050
# 1. Weights for a small set of keys can be overridden in task queue
5151
# configuration with an API.
5252
# 2. It can be attached to the workflow/activity in this field.
53-
# 3. The default weight of 1.0 will be used.
53+
# 3. The default fairness_weight of 1.0 will be used.
5454
#
5555
# Weight values are clamped to the range [0.001, 1000].
5656
class Priority
@@ -61,15 +61,15 @@ def self._from_proto(priority)
6161
new(
6262
priority_key: priority.priority_key.zero? ? nil : priority.priority_key,
6363
fairness_key: priority.fairness_key.empty? ? nil : priority.fairness_key,
64-
weight: priority.fairness_weight.zero? ? nil : priority.fairness_weight
64+
fairness_weight: priority.fairness_weight.zero? ? nil : priority.fairness_weight
6565
)
6666
end
6767

6868
# The default priority instance.
6969
#
7070
# @return [Priority] The default priority
7171
def self.default
72-
@default ||= new(priority_key: nil, fairness_key: nil, weight: nil)
72+
@default ||= new(priority_key: nil, fairness_key: nil, fairness_weight: nil)
7373
end
7474

7575
# @!visibility private
@@ -79,13 +79,13 @@ def _to_proto
7979
Temporalio::Api::Common::V1::Priority.new(
8080
priority_key: priority_key || 0,
8181
fairness_key: fairness_key || '',
82-
fairness_weight: weight || 0.0
82+
fairness_weight: fairness_weight || 0.0
8383
)
8484
end
8585

8686
# @return [Boolean] True if this priority is empty/default
8787
def empty?
88-
priority_key.nil? && fairness_key.nil? && weight.nil?
88+
priority_key.nil? && fairness_key.nil? && fairness_weight.nil?
8989
end
9090
end
9191
end

temporalio/sig/temporalio/priority.rbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ module Temporalio
22
class Priority
33
attr_reader priority_key: Integer?
44
attr_reader fairness_key: String?
5-
attr_reader weight: Float?
5+
attr_reader fairness_weight: Float?
66

7-
def initialize: (priority_key: Integer?, ?fairness_key: String?, ?weight: Float?) -> void
7+
def initialize: (priority_key: Integer?, ?fairness_key: String?, ?fairness_weight: Float?) -> void
88

99
def self._from_proto: (untyped) -> Priority
1010

temporalio/test/worker_workflow_priority_test.rb

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ def execute(expected_priority, expected_fairness_key = nil, expected_weight = ni
1111
info = Temporalio::Activity::Context.current.info
1212
actual_priority = info.priority&.priority_key
1313
actual_fairness_key = info.priority&.fairness_key
14-
actual_weight = info.priority&.weight
14+
actual_weight = info.priority&.fairness_weight
1515
[actual_priority, expected_priority, actual_fairness_key, expected_fairness_key, actual_weight, expected_weight]
1616
end
1717
end
@@ -28,7 +28,7 @@ def execute(expected_priority, stop_after_check, expected_fairness_key = nil, ex
2828
info = Temporalio::Workflow.info
2929
actual_priority = info.priority&.priority_key
3030
actual_fairness_key = info.priority&.fairness_key
31-
actual_weight = info.priority&.weight
31+
actual_weight = info.priority&.fairness_weight
3232

3333
raise "Expected priority #{expected_priority}, got #{actual_priority}" if actual_priority != expected_priority
3434
if actual_fairness_key != expected_fairness_key
@@ -45,7 +45,7 @@ def execute(expected_priority, stop_after_check, expected_fairness_key = nil, ex
4545
true,
4646
'tenant-a',
4747
2.0,
48-
priority: Temporalio::Priority.new(priority_key: 4, fairness_key: 'tenant-a', weight: 2.0)
48+
priority: Temporalio::Priority.new(priority_key: 4, fairness_key: 'tenant-a', fairness_weight: 2.0)
4949
)
5050
raise 'child workflow failed' unless child_result == 'Done!'
5151

@@ -55,7 +55,7 @@ def execute(expected_priority, stop_after_check, expected_fairness_key = nil, ex
5555
true,
5656
'tenant-b',
5757
0.5,
58-
priority: Temporalio::Priority.new(priority_key: 2, fairness_key: 'tenant-b', weight: 0.5)
58+
priority: Temporalio::Priority.new(priority_key: 2, fairness_key: 'tenant-b', fairness_weight: 0.5)
5959
)
6060
result = handle.result
6161
raise 'child workflow failed' unless result == 'Done!'
@@ -66,7 +66,7 @@ def execute(expected_priority, stop_after_check, expected_fairness_key = nil, ex
6666
'high',
6767
1.5,
6868
start_to_close_timeout: 5,
69-
priority: Temporalio::Priority.new(priority_key: 5, fairness_key: 'high', weight: 1.5)
69+
priority: Temporalio::Priority.new(priority_key: 5, fairness_key: 'high', fairness_weight: 1.5)
7070
)
7171
raise "Activity expected priority #{act_expected}, got #{act_actual}" if act_actual != act_expected
7272
if act_fairness_actual != act_fairness_expected
@@ -84,7 +84,7 @@ def test_workflow_priority
8484
execute_workflow(
8585
WorkflowUsingPriorities, 1, false, 'tenant-main', 0.8,
8686
activities: [ActivityWithPriority],
87-
priority: Temporalio::Priority.new(priority_key: 1, fairness_key: 'tenant-main', weight: 0.8)
87+
priority: Temporalio::Priority.new(priority_key: 1, fairness_key: 'tenant-main', fairness_weight: 0.8)
8888
) do |handle|
8989
assert_equal 'Done!', handle.result
9090

@@ -128,7 +128,7 @@ def test_workflow_priority
128128
execute_workflow(
129129
WorkflowUsingPriorities, nil, true, 'low', 0.2,
130130
activities: [ActivityWithPriority],
131-
priority: Temporalio::Priority.new(priority_key: nil, fairness_key: 'low', weight: 0.2)
131+
priority: Temporalio::Priority.new(priority_key: nil, fairness_key: 'low', fairness_weight: 0.2)
132132
) do |handle|
133133
assert_equal 'Done!', handle.result
134134

0 commit comments

Comments
 (0)