Propagate set_headers failure in client bridge

Author: THardy98

temporalio/ext/src/client.rs

@@ -237,8 +237,9 @@ impl Client {
         self.invoke_rpc(service, callback, call)
     }
 
-    pub fn update_metadata(&self, headers: HashMap<String, String>) {
-        self.core.get_client().set_headers(headers);
+    pub fn update_metadata(&self, headers: HashMap<String, String>) -> Result<(), Error> {
+        self.core.get_client().set_headers(headers)
+            .map_err(|err| error!("Invalid headers: {}", err))
     }
 
     pub fn update_api_key(&self, api_key: Option<String>) {

temporalio/lib/temporalio/cancellation.rb

@@ -167,8 +167,8 @@ def prepare_cancel(reason:)
       to_return.values
     end
 
-    def canceled_mutex_synchronize(&)
-      Workflow::Unsafe.illegal_call_tracing_disabled { @canceled_mutex.synchronize(&) }
+    def canceled_mutex_synchronize(&block)
+      Workflow::Unsafe.illegal_call_tracing_disabled { @canceled_mutex.synchronize(&block) }
     end
   end
 end

temporalio/lib/temporalio/internal/worker/workflow_instance/outbound_implementation.rb

@@ -121,7 +121,7 @@ def execute_local_activity(input)
             end
           end
 
-          def execute_activity_with_local_backoffs(local:, cancellation:, result_hint:, &)
+          def execute_activity_with_local_backoffs(local:, cancellation:, result_hint:, &block)
             # We do not even want to schedule if the cancellation is already cancelled. We choose to use canceled
             # failure instead of wrapping in activity failure which is similar to what other SDKs do, with the accepted
             # tradeoff that it makes rescue more difficult (hence the presence of Error.canceled? helper).
@@ -130,7 +130,7 @@ def execute_activity_with_local_backoffs(local:, cancellation:, result_hint:, &)
             # This has to be done in a loop for local activity backoff
             last_local_backoff = nil
             loop do
-              result = execute_activity_once(local:, cancellation:, last_local_backoff:, result_hint:, &)
+              result = execute_activity_once(local:, cancellation:, last_local_backoff:, result_hint:, &block)
               return result unless result.is_a?(Bridge::Api::ActivityResult::DoBackoff)
 
               # @type var result: untyped
@@ -142,9 +142,9 @@ def execute_activity_with_local_backoffs(local:, cancellation:, result_hint:, &)
           end
 
           # If this doesn't raise, it returns success | DoBackoff
-          def execute_activity_once(local:, cancellation:, last_local_backoff:, result_hint:, &)
+          def execute_activity_once(local:, cancellation:, last_local_backoff:, result_hint:, &block)
             # Add to pending activities (removed by the resolver)
-            seq = yield last_local_backoff
+            seq = block.call(last_local_backoff)
             @instance.pending_activities[seq] = Fiber.current
 
             # Add cancellation hook