Remove useless disable_file parameter for ClientConfig.load

Author: THardy98

temporalio/ext/src/envconfig.rs

@@ -117,19 +117,14 @@ fn load_client_config_inner(
     ruby: &Ruby,
     config_source: Option<DataSource>,
     config_file_strict: bool,
-    disable_file: bool,
     env_vars: Option<HashMap<String, String>>,
 ) -> Result<RHash, Error> {
-    let core_config = if disable_file {
-        CoreClientConfig::default()
-    } else {
-        let options = LoadClientConfigOptions {
-            config_source,
-            config_file_strict,
-        };
-        core_load_client_config(options, env_vars.as_ref())
-            .map_err(|e| error!("EnvConfig error: {}", e))?
+    let options = LoadClientConfigOptions {
+        config_source,
+        config_file_strict,
     };
+    let core_config = core_load_client_config(options, env_vars.as_ref())
+        .map_err(|e| error!("EnvConfig error: {}", e))?;
 
     core_config_to_hash(ruby, &core_config)
 }
@@ -157,18 +152,18 @@ fn load_client_connect_config_inner(
     profile_to_hash(ruby, &profile)
 }
 
-// load_client_config(path: String|nil, data: String|nil, disable_file: bool, config_file_strict: bool, env_vars: Hash|nil)
+// load_client_config(path: String|nil, data: String|nil, config_file_strict: bool, env_vars: Hash|nil)
 fn load_client_config(args: &[magnus::Value]) -> Result<RHash, Error> {
     let ruby = Ruby::get().expect("Not in Ruby thread");
     let args = scan_args::scan_args::<
-        (Option<String>, Option<RString>, bool, bool),
+        (Option<String>, Option<RString>, bool),
         (Option<HashMap<String, String>>,),
         (),
         (),
         (),
         (),
     >(args)?;
-    let (path, data, disable_file, config_file_strict) = args.required;
+    let (path, data, config_file_strict) = args.required;
     let (env_vars,) = args.optional;
 
     let config_source = match (path, data) {
@@ -189,7 +184,6 @@ fn load_client_config(args: &[magnus::Value]) -> Result<RHash, Error> {
         &ruby,
         config_source,
         config_file_strict,
-        disable_file,
         env_vars,
     )
 }

temporalio/lib/temporalio/env_config.rb

@@ -254,13 +254,11 @@ def self.from_h(hash)
       # (TEMPORAL_CONFIG_FILE).
       #
       # @param config_source [Pathname, String, nil] Configuration source
-      # @param disable_file [Boolean] If true, file loading is disabled
       # @param config_file_strict [Boolean] If true, will error on unrecognized keys
       # @param override_env_vars [Hash, nil] Environment variables to use
       # @return [ClientConfig] The client configuration
       def self.load(
         config_source: nil,
-        disable_file: false,
         config_file_strict: false,
         override_env_vars: nil
       )
@@ -269,7 +267,6 @@ def self.load(
         loaded_profiles = Internal::Bridge::EnvConfig.load_client_config(
           path,
           data,
-          disable_file,
           config_file_strict,
           override_env_vars || {}
         )

temporalio/test/envconfig_test.rb

@@ -336,12 +336,6 @@ def test_load_profiles_discovery
     end
   end
 
-  def test_load_profiles_disable_file
-    # With no env vars, should be empty
-    client_config = Temporalio::EnvConfig::ClientConfig.load(disable_file: true, override_env_vars: {})
-    assert_empty client_config.profiles
-  end
-
   def test_default_profile_not_found_returns_empty_profile
     toml = <<~TOML
       [profile.existing]