CI fixes

Author: cretz

.github/workflows/ci.yml

@@ -73,4 +73,6 @@ jobs:
 
       - name: Lint, compile, test Ruby
         working-directory: ./temporalio
+        # Timeout just in case there's a hanging part in rake
+        timeout-minutes: 20
         run: bundle exec rake TESTOPTS="--verbose"

README.md

@@ -1,6 +1,6 @@
 <div style="overflow: hidden"><img src="https://raw.githubusercontent.com/temporalio/assets/main/files/w/ruby.png" alt="Temporal Ruby SDK" /></div>
 
-![Ruby 3.1 | 3.2 | 3.3 | 3.4](https://img.shields.io/badge/ruby-3.1%20%7C%203.2%20%7C%203.3-blue.svg?style=for-the-badge)
+![Ruby 3.1 | 3.2 | 3.3](https://img.shields.io/badge/ruby-3.1%20%7C%203.2%20%7C%203.3-blue.svg?style=for-the-badge)
 [![MIT](https://img.shields.io/github/license/temporalio/sdk-ruby.svg?style=for-the-badge)](LICENSE)
 [![Gem](https://img.shields.io/gem/v/temporalio?style=for-the-badge)](https://rubygems.org/gems/temporalio)
 
@@ -59,6 +59,8 @@ until the SDK is marked stable.
 
 ### Installation
 
+The Ruby SDK works with Ruby 3.1, 3.2, and 3.3. 3.4 support will be added soon, and 3.1 support will be dropped soon.
+
 Can require in a Gemfile like:
 
 ```

temporalio/Gemfile

@@ -17,7 +17,7 @@ group :development do
   gem 'rbs', '~> 3.5.3'
   gem 'rb_sys', '~> 0.9.63'
   gem 'rubocop'
-  gem 'sqlite3', '~> 1.4'
+  gem 'sqlite3'
   gem 'steep', '~> 1.7.1'
   gem 'yard'
 end

temporalio/lib/temporalio/client/schedule.rb

@@ -958,7 +958,8 @@ def initialize(raw_info)
 
         State = Struct.new(
           :note,
-          :paused
+          :paused,
+          keyword_init: true
         )
 
         # State of a listed schedule.

temporalio/lib/temporalio/internal/worker/workflow_instance/illegal_call_tracer.rb

@@ -33,31 +33,45 @@ def self.frozen_validated_illegal_calls(illegal_calls)
             end.freeze
           end
 
-          # Illegal calls are Hash[String, Hash[Symbol, Bool]]
+          # Illegal calls are Hash[String, :all | Hash[Symbol, Bool]]
           def initialize(illegal_calls)
             @tracepoint = TracePoint.new(:call, :c_call) do |tp|
               cls = tp.defined_class
               next unless cls.is_a?(Module)
 
-              # We need this to be quick so we don't do extra validations to satisfy type checker
-              # steep:ignore:start
-              if cls.singleton_class?
-                cls = cls.attached_object
-                next unless cls.is_a?(Module)
-              end
-              vals = illegal_calls[cls.name]
-              if vals == :all || vals&.[](tp.callee_id)
+              # Extract the class name from the defined class. This is more difficult than it seems because you have to
+              # resolve the attached object of the singleton class. But in older Ruby (at least <= 3.1), the singleton
+              # class of things like `Date` does not have `attached_object` so you have to fall back in these rare cases
+              # to parsing the string output. Reaching the string parsing component is rare, so this should not have
+              # significant performance impact.
+              cls_name = if cls.singleton_class?
+                           if cls.respond_to?(:attached_object)
+                             cls = cls.attached_object # steep:ignore
+                             next unless cls.is_a?(Module)
+
+                             cls.name.to_s
+                           else
+                             cls.to_s.delete_prefix('#<Class:').delete_suffix('>')
+                           end
+                         else
+                           cls.name.to_s
+                         end
+
+              # Check if the call is considered illegal
+              vals = illegal_calls[cls_name]
+              if vals == :all || vals&.[](tp.callee_id) # steep:ignore
                 raise Workflow::NondeterminismError,
-                      "Cannot access #{cls.name} #{tp.callee_id} from inside a " \
+                      "Cannot access #{cls_name} #{tp.callee_id} from inside a " \
                       'workflow. If this is known to be safe, the code can be run in ' \
                       'a Temporalio::Workflow::Unsafe.illegal_call_tracing_disabled block.'
               end
-              # steep:ignore:end
             end
           end
 
           def enable(&)
-            @tracepoint.enable(&)
+            # Setting current thread explicitly because it wasn't until Ruby 3.2 that this
+            # was done automatically, ref https://github.com/ruby/ruby/pull/5359
+            @tracepoint.enable(target_thread: Thread.current, &)
           end
 
           def disable(&)

temporalio/lib/temporalio/worker/interceptor.rb

@@ -273,7 +273,8 @@ def handle_update(input)
         SleepInput = Struct.new(
           :duration,
           :summary,
-          :cancellation
+          :cancellation,
+          keyword_init: true
         )
 
         # Input for {Outbound.start_child_workflow}.

temporalio/lib/temporalio/workflow/info.rb

@@ -74,7 +74,8 @@ class Info
       ParentInfo = Struct.new(
         :namespace,
         :run_id,
-        :workflow_id
+        :workflow_id,
+        keyword_init: true
       )
     end
   end

temporalio/test/api/payload_visitor_test.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
 
 require 'temporalio/api/payload_visitor'
-require 'test_base'
+require 'test'
 
 module Api
-  class PayloadVisitorTest < TestBase
+  class PayloadVisitorTest < Test
     def test_basics
       # Make protos that have:
       # * single payload

temporalio/test/cancellation_test.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
 
 require 'temporalio/cancellation'
-require 'test_base'
+require 'test'
 
-class CancellationTest < TestBase
+class CancellationTest < Test
   also_run_all_tests_in_fiber
 
   def test_simple_cancellation

temporalio/test/client_schedule_test.rb

@@ -4,9 +4,9 @@
 require 'temporalio/client'
 require 'temporalio/client/schedule'
 require 'temporalio/testing'
-require 'test_base'
+require 'test'
 
-class ClientScheduleTest < TestBase
+class ClientScheduleTest < Test
   also_run_all_tests_in_fiber
 
   def test_basics # rubocop:disable Metrics/AbcSize,Metrics/MethodLength