Skip to content

Commit 02ab64c

Browse files
authored
Fixes bug where we were not persisting the failure details for a marker recorded event, which corrupts workflow on replay #712
We are not persisting the failure details on an incoming RecordLocalMarkerCommand. As a result on replay, if we have recorded a local activity failure, the SDK will panic since the expected failure field is missing.
1 parent 50de8a2 commit 02ab64c

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

service/history/historyBuilder.go

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -700,6 +700,7 @@ func (b *historyBuilder) newMarkerRecordedEventAttributes(workflowTaskCompletedE
700700
attributes.Details = request.Details
701701
attributes.WorkflowTaskCompletedEventId = workflowTaskCompletedEventID
702702
attributes.Header = request.Header
703+
attributes.Failure = request.Failure
703704
historyEvent.Attributes = &historypb.HistoryEvent_MarkerRecordedEventAttributes{MarkerRecordedEventAttributes: attributes}
704705

705706
return historyEvent

0 commit comments

Comments
 (0)