Skip to content

Commit 09b4ca9

Browse files
committed
Remove noop
1 parent 9a6375e commit 09b4ca9

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

service/history/handler.go

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -228,9 +228,6 @@ func (h *Handler) DeepHealthCheck(
228228
// checkHistoryHealthSignals checks the history health signal that is captured by the interceptor.
229229
func (h *Handler) checkHistoryHealthSignals() *historyservice.DeepHealthCheckResponse {
230230
// Check that the RPC latency doesn't exceed the threshold.
231-
if _, ok := h.historyHealthSignal.(*interceptor.NoopSignalAggregator); ok {
232-
h.logger.Warn("health signal aggregator is using noop implementation")
233-
}
234231
if h.historyHealthSignal.AverageLatency() > h.config.HealthRPCLatencyFailure() {
235232
metrics.HistoryHostHealthGauge.With(h.metricsHandler).Record(float64(enumsspb.HEALTH_STATE_NOT_SERVING))
236233
return &historyservice.DeepHealthCheckResponse{State: enumsspb.HEALTH_STATE_NOT_SERVING}

0 commit comments

Comments
 (0)