Remove unused history event check (#3373)

yux0 · yux0 · commit 0dd2b6b5c564 · 2022-09-15T10:43:34.000-07:00
diff --git a/service/history/workflow/context.go b/service/history/workflow/context.go
@@ -672,16 +672,13 @@ func (c *ContextImpl) SetWorkflowExecution(ctx context.Context, now time.Time) (
 		}
 	}()
 
-	resetWorkflowSnapshot, resetWorkflowEventsSeq, err := c.MutableState.CloseTransactionAsSnapshot(
+	resetWorkflowSnapshot, _, err := c.MutableState.CloseTransactionAsSnapshot(
 		now,
 		TransactionPolicyPassive,
 	)
 	if err != nil {
 		return err
 	}
-	if len(resetWorkflowEventsSeq) != 0 {
-		return serviceerror.NewInternal("SetWorkflowExecution encountered new events")
-	}
 
 	resetWorkflowSnapshot.ExecutionInfo.ExecutionStats = &persistencespb.ExecutionStats{
 		HistorySize: c.GetHistorySize(),

Original file line number	Diff line number	Diff line change
`@@ -672,16 +672,13 @@ func (c *ContextImpl) SetWorkflowExecution(ctx context.Context, now time.Time) (`
`672`	`672`	`}`
`673`	`673`	`}()`
`674`	`674`
`675`		`- resetWorkflowSnapshot, resetWorkflowEventsSeq, err := c.MutableState.CloseTransactionAsSnapshot(`
	`675`	`+ resetWorkflowSnapshot, _, err := c.MutableState.CloseTransactionAsSnapshot(`
`676`	`676`	`now,`
`677`	`677`	`TransactionPolicyPassive,`
`678`	`678`	`)`
`679`	`679`	`if err != nil {`
`680`	`680`	`return err`
`681`	`681`	`}`
`682`		`- if len(resetWorkflowEventsSeq) != 0 {`
`683`		`- return serviceerror.NewInternal("SetWorkflowExecution encountered new events")`
`684`		`- }`
`685`	`682`
`686`	`683`	`resetWorkflowSnapshot.ExecutionInfo.ExecutionStats = &persistencespb.ExecutionStats{`
`687`	`684`	`HistorySize: c.GetHistorySize(),`