Remove timestamp rounding to avoid preliminary timer firing (#765)

Author: mfateev

host/activity_test.go

@@ -220,9 +220,9 @@ func (s *integrationSuite) TestActivityHeartbeatDetailsDuringRetry() {
 						ActivityType:           &commonpb.ActivityType{Name: activityName},
 						TaskQueue:              &taskqueuepb.TaskQueue{Name: tl},
 						Input:                  nil,
-						ScheduleToCloseTimeout: timestamp.DurationPtr(4 * time.Second),
-						ScheduleToStartTimeout: timestamp.DurationPtr(4 * time.Second),
-						StartToCloseTimeout:    timestamp.DurationPtr(4 * time.Second),
+						ScheduleToCloseTimeout: timestamp.DurationPtr(8 * time.Second),
+						ScheduleToStartTimeout: timestamp.DurationPtr(8 * time.Second),
+						StartToCloseTimeout:    timestamp.DurationPtr(8 * time.Second),
 						HeartbeatTimeout:       timestamp.DurationPtr(1 * time.Second),
 						RetryPolicy: &commonpb.RetryPolicy{
 							InitialInterval:    timestamp.DurationPtr(1 * time.Second),

service/history/timerSequence.go

@@ -99,10 +99,9 @@ func (t *timerSequenceImpl) isExpired(
 	referenceTime time.Time,
 	timerSequenceID timerSequenceID,
 ) bool {
-
-	// Cassandra timestamp resolution is in millisecond
-	// here we do the check in terms of second resolution.
-	return timerSequenceID.timestamp.Unix() <= referenceTime.Unix()
+	// TODO: Cassandra timestamp resolution is in millisecond.
+	// Verify if it can create any problem here.
+	return !timerSequenceID.timestamp.After(referenceTime)
 }
 
 func (t *timerSequenceImpl) createNextUserTimer() (bool, error) {