Add Value method to VisibilityValue

Author: awln-temporal

chasm/search_attribute.go

@@ -223,6 +223,8 @@ func (s SearchAttributeBool) Value(value bool) SearchAttributeKeyValue {
 
 func (s SearchAttributeBool) typeMarker(_ bool) {}
 
+func (s SearchAttributeBool) visibilityValueMarker(v VisibilityValueBool) {}
+
 // SearchAttributeDateTime is a search attribute for a datetime value.
 type SearchAttributeDateTime struct {
 	searchAttributeDefinition
@@ -260,6 +262,8 @@ func (s SearchAttributeDateTime) Value(value time.Time) SearchAttributeKeyValue
 
 func (s SearchAttributeDateTime) typeMarker(_ time.Time) {}
 
+func (s SearchAttributeDateTime) visibilityValueMarker(v VisibilityValueTime) {}
+
 // SearchAttributeInt is a search attribute for an integer value.
 type SearchAttributeInt struct {
 	searchAttributeDefinition
@@ -297,6 +301,8 @@ func (s SearchAttributeInt) Value(value int64) SearchAttributeKeyValue {
 
 func (s SearchAttributeInt) typeMarker(_ int64) {}
 
+func (s SearchAttributeInt) visibilityValueMarker(v VisibilityValueInt64) {}
+
 // SearchAttributeDouble is a search attribute for a double value.
 type SearchAttributeDouble struct {
 	searchAttributeDefinition
@@ -334,6 +340,8 @@ func (s SearchAttributeDouble) Value(value float64) SearchAttributeKeyValue {
 
 func (s SearchAttributeDouble) typeMarker(_ float64) {}
 
+func (s SearchAttributeDouble) visibilityValueMarker(v VisibilityValueFloat64) {}
+
 // SearchAttributeKeyword is a search attribute for a keyword value.
 type SearchAttributeKeyword struct {
 	searchAttributeDefinition
@@ -371,6 +379,8 @@ func (s SearchAttributeKeyword) Value(value string) SearchAttributeKeyValue {
 
 func (s SearchAttributeKeyword) typeMarker(_ string) {}
 
+func (s SearchAttributeKeyword) visibilityValueMarker(v VisibilityValueString) {}
+
 // SearchAttributeKeywordList is a search attribute for a keyword list value.
 type SearchAttributeKeywordList struct {
 	searchAttributeDefinition
@@ -408,6 +418,8 @@ func (s SearchAttributeKeywordList) Value(value []string) SearchAttributeKeyValu
 
 func (s SearchAttributeKeywordList) typeMarker(_ []string) {}
 
+func (s SearchAttributeKeywordList) visibilityValueMarker(v VisibilityValueStringSlice) {}
+
 // SearchAttributesMap wraps search attribute values with type-safe access.
 type SearchAttributesMap struct {
 	values map[string]VisibilityValue
@@ -434,7 +446,7 @@ func GetValue[T any](m SearchAttributesMap, sa typedSearchAttribute[T]) (val T,
 		return zero, false
 	}
 
-	finalVal, ok := visibilityValue.(T)
+	finalVal, ok := visibilityValue.Value().(T)
 	if !ok {
 		return zero, false
 	}

chasm/visibility_value.go

@@ -13,6 +13,7 @@ import (
 type VisibilityValue interface {
 	MustEncode() *commonpb.Payload
 	Equal(VisibilityValue) bool
+	Value() any
 }
 
 type VisibilityValueInt int
@@ -31,6 +32,10 @@ func (v VisibilityValueInt) Equal(other VisibilityValue) bool {
 	return v == ov
 }
 
+func (v VisibilityValueInt) Value() any {
+	return int(v)
+}
+
 type VisibilityValueInt32 int32
 
 func (v VisibilityValueInt32) MustEncode() *commonpb.Payload {
@@ -47,6 +52,10 @@ func (v VisibilityValueInt32) Equal(other VisibilityValue) bool {
 	return v == ov
 }
 
+func (v VisibilityValueInt32) Value() any {
+	return int32(v)
+}
+
 type VisibilityValueInt64 int64
 
 func (v VisibilityValueInt64) MustEncode() *commonpb.Payload {
@@ -63,6 +72,10 @@ func (v VisibilityValueInt64) Equal(other VisibilityValue) bool {
 	return v == ov
 }
 
+func (v VisibilityValueInt64) Value() any {
+	return int64(v)
+}
+
 type VisibilityValueString string
 
 func (v VisibilityValueString) MustEncode() *commonpb.Payload {
@@ -79,6 +92,10 @@ func (v VisibilityValueString) Equal(other VisibilityValue) bool {
 	return v == ov
 }
 
+func (v VisibilityValueString) Value() any {
+	return string(v)
+}
+
 type VisibilityValueBool bool
 
 func (v VisibilityValueBool) MustEncode() *commonpb.Payload {
@@ -95,6 +112,10 @@ func (v VisibilityValueBool) Equal(other VisibilityValue) bool {
 	return v == ov
 }
 
+func (v VisibilityValueBool) Value() any {
+	return bool(v)
+}
+
 type VisibilityValueFloat64 float64
 
 func (v VisibilityValueFloat64) MustEncode() *commonpb.Payload {
@@ -111,6 +132,10 @@ func (v VisibilityValueFloat64) Equal(other VisibilityValue) bool {
 	return v == ov
 }
 
+func (v VisibilityValueFloat64) Value() any {
+	return float64(v)
+}
+
 type VisibilityValueTime time.Time
 
 func (v VisibilityValueTime) MustEncode() *commonpb.Payload {
@@ -127,6 +152,10 @@ func (v VisibilityValueTime) Equal(other VisibilityValue) bool {
 	return time.Time(v).Equal(time.Time(ov))
 }
 
+func (v VisibilityValueTime) Value() any {
+	return time.Time(v)
+}
+
 type VisibilityValueByteSlice []byte
 
 func (v VisibilityValueByteSlice) MustEncode() *commonpb.Payload {
@@ -141,6 +170,10 @@ func (v VisibilityValueByteSlice) Equal(other VisibilityValue) bool {
 	return slices.Equal(v, ov)
 }
 
+func (v VisibilityValueByteSlice) Value() any {
+	return []byte(v)
+}
+
 type VisibilityValueStringSlice []string
 
 func (v VisibilityValueStringSlice) MustEncode() *commonpb.Payload {
@@ -157,6 +190,10 @@ func (v VisibilityValueStringSlice) Equal(other VisibilityValue) bool {
 	return slices.Equal(v, ov)
 }
 
+func (v VisibilityValueStringSlice) Value() any {
+	return []string(v)
+}
+
 func isVisibilityValueEqual(v1, v2 VisibilityValue) bool {
 	if v1 == nil && v2 == nil {
 		return true