Address the rest of the review comments

Author: bergundy

common/dynamicconfig/constants.go

@@ -214,7 +214,7 @@ const (
 	// This setting allows some propogation delay of versioning data, which may happen for the following reasons:
 	// 1. There are no workflows currently marked as open in the visibility store but a worker for the demoted version
 	// is currently processing a task.
-	// 2. There are delays in the asynchrnous visiblity task processor.
+	// 2. There are delays in the visibility task processor (which is asynchronous).
 	// 3. There's propagation delay of the versioning data between matching nodes.
 	RemovableBuildIdDurationSinceDefault = "worker.removableBuildIdDurationSinceDefault"
 

common/util/util.go

@@ -144,8 +144,8 @@ func FilterSlice[T any](in []T, predicate func(T) bool) []T {
 	return out
 }
 
-// ReduceSliceInitial reduces a slice using given reducer function and initial value.
-func ReduceSliceInitial[T any, A any](in []T, initializer A, reducer func(A, T) A) A {
+// ReduceSlice reduces a slice using given reducer function and initial value.
+func ReduceSlice[T any, A any](in []T, initializer A, reducer func(A, T) A) A {
 	acc := initializer
 	for _, val := range in {
 		acc = reducer(acc, val)

service/frontend/task_reachability.go

@@ -187,7 +187,7 @@ func (wh *WorkflowHandler) getTaskQueueReachability(ctx context.Context, request
 			reachableByNewWorkflows = true
 		} else {
 			// If the queue became versioned just recently, consider the unversioned build id reachable.
-			queueBecameVersionedAt := util.ReduceSliceInitial(versionSets, hlc.Clock{WallClock: math.MaxInt64}, func(c hlc.Clock, set *persistencespb.CompatibleVersionSet) hlc.Clock {
+			queueBecameVersionedAt := util.ReduceSlice(versionSets, hlc.Clock{WallClock: math.MaxInt64}, func(c hlc.Clock, set *persistencespb.CompatibleVersionSet) hlc.Clock {
 				return hlc.Min(c, *set.BecameDefaultTimestamp)
 			})
 			reachableByNewWorkflows = time.Since(hlc.UTC(queueBecameVersionedAt)) < wh.config.ReachabilityQuerySetDurationSinceDefault()