Skip to content

Commit 4e9acc3

Browse files
committed
Fail QueryWorkflow if last WorkflowTask failed
1 parent deb9821 commit 4e9acc3

File tree

3 files changed

+13
-3
lines changed

3 files changed

+13
-3
lines changed

go.mod

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,6 +64,8 @@ require (
6464
modernc.org/sqlite v1.21.0
6565
)
6666

67+
require golang.org/x/lint v0.0.0-20210508222113-6edffad5e616 // indirect
68+
6769
require (
6870
cloud.google.com/go v0.110.0 // indirect
6971
cloud.google.com/go/compute v1.18.0 // indirect
@@ -122,11 +124,11 @@ require (
122124
go.opentelemetry.io/proto/otlp v0.19.0 // indirect
123125
go.uber.org/dig v1.16.1 // indirect
124126
golang.org/x/crypto v0.6.0 // indirect
125-
golang.org/x/mod v0.8.0 // indirect
127+
golang.org/x/mod v0.9.0 // indirect
126128
golang.org/x/net v0.8.0 // indirect
127129
golang.org/x/sys v0.6.0 // indirect
128130
golang.org/x/text v0.8.0 // indirect
129-
golang.org/x/tools v0.6.0 // indirect
131+
golang.org/x/tools v0.7.0 // indirect
130132
golang.org/x/xerrors v0.0.0-20220907171357-04be3eba64a2 // indirect
131133
google.golang.org/appengine v1.6.7 // indirect
132134
google.golang.org/genproto v0.0.0-20230322174352-cde4c949918d // indirect

go.sum

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1111,6 +1111,7 @@ golang.org/x/lint v0.0.0-20191125180803-fdd1cda4f05f/go.mod h1:5qLYkcX4OjUUV8bRu
11111111
golang.org/x/lint v0.0.0-20200130185559-910be7a94367/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY=
11121112
golang.org/x/lint v0.0.0-20200302205851-738671d3881b/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY=
11131113
golang.org/x/lint v0.0.0-20201208152925-83fdc39ff7b5/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY=
1114+
golang.org/x/lint v0.0.0-20210508222113-6edffad5e616 h1:VLliZ0d+/avPrXXH+OakdXhpJuEoBZuwh1m2j7U6Iug=
11141115
golang.org/x/lint v0.0.0-20210508222113-6edffad5e616/go.mod h1:3xt1FjdF8hUf6vQPIChWIBhFzV8gjjsPE/fR3IyQdNY=
11151116
golang.org/x/mobile v0.0.0-20190312151609-d3739f865fa6/go.mod h1:z+o9i4GpDbdi3rU15maQ/Ox0txvL9dWGYEHz965HBQE=
11161117
golang.org/x/mobile v0.0.0-20190719004257-d2bd2a29d028/go.mod h1:E/iHnbuqvinMTCcRqshq8CkpyQDoeVncDDYHnLhea+o=
@@ -1129,6 +1130,7 @@ golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4/go.mod h1:jJ57K6gSWd91
11291130
golang.org/x/mod v0.7.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
11301131
golang.org/x/mod v0.8.0 h1:LUYupSeNrTNCGzR/hVBk2NHZO4hXcVaW1k4Qx7rjPx8=
11311132
golang.org/x/mod v0.8.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
1133+
golang.org/x/mod v0.9.0/go.mod h1:iBbtSCu2XBx23ZKBPSOrRkjjQPZFPuis4dIYUhu/chs=
11321134
golang.org/x/net v0.0.0-20180724234803-3673e40ba225/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
11331135
golang.org/x/net v0.0.0-20180826012351-8a410e7b638d/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
11341136
golang.org/x/net v0.0.0-20181114220301-adae6a3d119a/go.mod h1:mL1N/T3taQHkDXs73rZJwtUhF3w3ftmwwsq0BUmARs4=
@@ -1414,6 +1416,8 @@ golang.org/x/tools v0.1.12/go.mod h1:hNGJHUnrk76NpqgfD5Aqm5Crs+Hm0VOH/i9J2+nxYbc
14141416
golang.org/x/tools v0.3.0/go.mod h1:/rWhSS2+zyEVwoJf8YAX6L2f0ntZ7Kn/mGgAWcipA5k=
14151417
golang.org/x/tools v0.6.0 h1:BOw41kyTf3PuCW1pVQf8+Cyg8pMlkYB1oo9iJ6D/lKM=
14161418
golang.org/x/tools v0.6.0/go.mod h1:Xwgl3UAJ/d3gWutnCtw505GrjyAbvKui8lOU390QaIU=
1419+
golang.org/x/tools v0.7.0 h1:W4OVu8VVOaIO0yzWMNdepAulS7YfoS3Zabrm8DOXXU4=
1420+
golang.org/x/tools v0.7.0/go.mod h1:4pg6aUX35JBAogB10C9AtvVL+qowtN4pT3CGSQex14s=
14171421
golang.org/x/xerrors v0.0.0-20190717185122-a985d3407aa7/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
14181422
golang.org/x/xerrors v0.0.0-20191011141410-1b5146add898/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=
14191423
golang.org/x/xerrors v0.0.0-20191204190536-9bdfabe68543/go.mod h1:I/5z698sn9Ka8TeJc9MKroUUfqBBauWjQqLJ2OPfmY0=

tests/query_workflow_test.go

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -262,10 +262,14 @@ func (s *clientIntegrationSuite) TestQueryWorkflow_QueryBeforeStart() {
262262
func (s *clientIntegrationSuite) TestQueryWorkflow_QueryFailedWorkflowTask() {
263263

264264
workflowFn := func(ctx workflow.Context) (string, error) {
265-
workflow.SetQueryHandler(ctx, "test", func() (string, error) {
265+
err := workflow.SetQueryHandler(ctx, "test", func() (string, error) {
266266
return "", nil
267267
})
268268

269+
if err != nil {
270+
s.Logger.Fatal("SetQueryHandler failed: " + err.Error())
271+
}
272+
269273
// force workflow task to fail
270274
panic("Workflow failed")
271275
}

0 commit comments

Comments
 (0)