Skip to content

Commit 56c6dde

Browse files
committed
fix lint
1 parent 6c3d2eb commit 56c6dde

File tree

2 files changed

+9
-9
lines changed

2 files changed

+9
-9
lines changed

service/worker/workerdeployment/util.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -139,23 +139,23 @@ func DecodeWorkerDeploymentMemo(memo *commonpb.Memo) *deploymentspb.WorkerDeploy
139139
workerDeploymentWorkflowMemo.RoutingConfig = &deploymentpb.RoutingConfig{}
140140
}
141141
rc := workerDeploymentWorkflowMemo.RoutingConfig
142-
if rc.CurrentVersion == "" {
142+
if rc.CurrentVersion == "" { //nolint:staticcheck
143143
rc.CurrentVersion = worker_versioning.WorkerDeploymentVersionToStringV31(rc.CurrentDeploymentVersion) //nolint:staticcheck
144144
}
145-
if rc.RampingVersion == "" {
145+
if rc.RampingVersion == "" { //nolint:staticcheck
146146
rc.RampingVersion = worker_versioning.WorkerDeploymentVersionToStringV31(rc.RampingDeploymentVersion) //nolint:staticcheck
147147
}
148148

149149
if latest := workerDeploymentWorkflowMemo.GetLatestVersionSummary(); latest != nil {
150-
latest.Version = worker_versioning.WorkerDeploymentVersionToStringV31(latest.GetDeploymentVersion())
150+
latest.Version = worker_versioning.WorkerDeploymentVersionToStringV31(latest.GetDeploymentVersion()) //nolint:staticcheck
151151
}
152152

153153
if current := workerDeploymentWorkflowMemo.GetCurrentVersionSummary(); current != nil {
154-
current.Version = worker_versioning.WorkerDeploymentVersionToStringV31(current.GetDeploymentVersion())
154+
current.Version = worker_versioning.WorkerDeploymentVersionToStringV31(current.GetDeploymentVersion()) //nolint:staticcheck
155155
}
156156

157157
if ramping := workerDeploymentWorkflowMemo.GetRampingVersionSummary(); ramping != nil {
158-
ramping.Version = worker_versioning.WorkerDeploymentVersionToStringV31(ramping.GetDeploymentVersion())
158+
ramping.Version = worker_versioning.WorkerDeploymentVersionToStringV31(ramping.GetDeploymentVersion()) //nolint:staticcheck
159159
}
160160

161161
return &workerDeploymentWorkflowMemo

tests/worker_deployment_test.go

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1259,10 +1259,10 @@ func (s *WorkerDeploymentSuite) TestSetWorkerDeploymentRampingVersion_Unversione
12591259
"ramping non-zero traffic to unversioned is not supported",
12601260
&workflowservice.SetWorkerDeploymentRampingVersionResponse{PreviousVersion: worker_versioning.UnversionedVersionId})
12611261

1262-
//// check that the current version's task queues have ramping version == __unversioned__
1263-
//for i := 0; i < taskQueues; i++ {
1264-
// s.verifyTaskQueueVersioningInfo(ctx, tv.WithTaskQueueNumber(i).TaskQueue(), tv.DeploymentVersionString(), worker_versioning.UnversionedVersionId, 75)
1265-
//}
1262+
// // check that the current version's task queues have ramping version == __unversioned__
1263+
// for i := 0; i < taskQueues; i++ {
1264+
// s.verifyTaskQueueVersioningInfo(ctx, tv.WithTaskQueueNumber(i).TaskQueue(), tv.DeploymentVersionString(), worker_versioning.UnversionedVersionId, 75)
1265+
// }
12661266

12671267
}
12681268

0 commit comments

Comments
 (0)