Skip to content

Commit 6107df5

Browse files
authored
reduce unnecessary logging (#2549)
1 parent f7952b4 commit 6107df5

File tree

3 files changed

+22
-3
lines changed

3 files changed

+22
-3
lines changed

client/history/metricClient.go

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@ package history
2727
import (
2828
"context"
2929

30+
"go.temporal.io/api/serviceerror"
3031
"google.golang.org/grpc"
3132

3233
"go.temporal.io/server/api/historyservice/v1"
@@ -627,7 +628,15 @@ func (c *metricClient) finishMetricsRecording(
627628
err error,
628629
) {
629630
if err != nil {
630-
c.throttledLogger.Error("history client encountered error", tag.Error(err), tag.ErrorType(err))
631+
switch err.(type) {
632+
case *serviceerror.Canceled,
633+
*serviceerror.DeadlineExceeded,
634+
*serviceerror.NotFound,
635+
*serviceerror.WorkflowExecutionAlreadyStarted:
636+
// noop - not interest and too many logs
637+
default:
638+
c.throttledLogger.Error("history client encountered error", tag.Error(err), tag.ErrorType(err))
639+
}
631640
scope.Tagged(metrics.ServiceErrorTypeTag(err)).IncCounter(metrics.ClientFailures)
632641
}
633642
stopwatch.Stop()

client/matching/metricClient.go

Lines changed: 11 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ import (
2828
"context"
2929
"strings"
3030

31+
"go.temporal.io/api/serviceerror"
3132
taskqueuepb "go.temporal.io/api/taskqueue/v1"
3233
"google.golang.org/grpc"
3334

@@ -256,7 +257,16 @@ func (c *metricClient) finishMetricsRecording(
256257
err error,
257258
) {
258259
if err != nil {
259-
c.throttledLogger.Error("matching client encountered error", tag.Error(err), tag.ErrorType(err))
260+
switch err.(type) {
261+
case *serviceerror.Canceled,
262+
*serviceerror.DeadlineExceeded,
263+
*serviceerror.NotFound,
264+
*serviceerror.WorkflowExecutionAlreadyStarted:
265+
// noop - not interest and too many logs
266+
default:
267+
268+
c.throttledLogger.Error("matching client encountered error", tag.Error(err), tag.ErrorType(err))
269+
}
260270
scope.Tagged(metrics.ServiceErrorTypeTag(err)).IncCounter(metrics.ClientFailures)
261271
}
262272
stopwatch.Stop()

service/history/replicationTaskProcessor.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -493,7 +493,7 @@ func (p *ReplicationTaskProcessorImpl) cleanupReplicationTasks() error {
493493
return nil
494494
}
495495

496-
p.logger.Info("cleaning up replication task queue", tag.ReadLevel(*minAckedTaskID))
496+
p.logger.Debug("cleaning up replication task queue", tag.ReadLevel(*minAckedTaskID))
497497
p.metricsClient.Scope(metrics.ReplicationTaskCleanupScope).IncCounter(metrics.ReplicationTaskCleanupCount)
498498
p.metricsClient.Scope(
499499
metrics.ReplicationTaskFetcherScope,

0 commit comments

Comments
 (0)