Add remaining test suites

Author: awln-temporal

chasm/engine.go

@@ -97,12 +97,18 @@ type ListChasmExecutionsOptions struct {
 
 type ListChasmExecutionsOption func(*ListChasmExecutionsOptions)
 
-func WithPagination(
+func WithPageSize(
 	pageSize int,
-	nextPageToken []byte,
 ) ListChasmExecutionsOption {
 	return func(req *ListChasmExecutionsOptions) {
 		req.PageSize = pageSize
+	}
+}
+
+func WithNextPageToken(
+	nextPageToken []byte,
+) ListChasmExecutionsOption {
+	return func(req *ListChasmExecutionsOptions) {
 		req.NextPageToken = nextPageToken
 	}
 }

chasm/registrable_component.go

@@ -120,11 +120,6 @@ func (rc *RegistrableComponent) SearchAttributesMapper() *VisibilitySearchAttrib
 	return rc.searchAttributesMapper
 }
 
-// ComponentType returns the component type name.
-func (rc *RegistrableComponent) ComponentType() string {
-	return rc.componentType
-}
-
 // fqType returns the fully qualified name of the component, which is a combination of
 // the library name and the component type. This is used to uniquely identify
 // the component in the registry.

chasm/tree_test.go

@@ -87,7 +87,6 @@ func (s *nodeSuite) initAssertions() {
 }
 
 // Test helper functions to avoid hardcoded values and testvars dependency
-
 func newTestEntityKey() EntityKey {
 	return EntityKey{
 		NamespaceID: primitives.NewUUID().String(),

common/persistence/visibility/store/elasticsearch/query_interceptors_test.go

@@ -37,6 +37,7 @@ func (s *QueryInterceptorSuite) TestTimeProcessFunc() {
 	vi := NewValuesInterceptor(
 		"test-namespace",
 		searchattribute.TestEsNameTypeMap(),
+		nil,
 	)
 
 	cases := []struct {
@@ -74,6 +75,7 @@ func (s *QueryInterceptorSuite) TestStatusProcessFunc() {
 	vi := NewValuesInterceptor(
 		"test-namespace",
 		searchattribute.TestEsNameTypeMap(),
+		nil,
 	)
 
 	cases := []struct {
@@ -117,6 +119,7 @@ func (s *QueryInterceptorSuite) TestDurationProcessFunc() {
 	vi := NewValuesInterceptor(
 		"test-namespace",
 		searchattribute.TestEsNameTypeMap(),
+		nil,
 	)
 
 	cases := []struct {
@@ -173,6 +176,7 @@ func (s *QueryInterceptorSuite) TestValuesInterceptor_ScheduleIDToWorkflowID() {
 	vi := NewValuesInterceptor(
 		"test-namespace",
 		searchattribute.TestEsNameTypeMap(),
+		nil,
 	)
 
 	values, err := vi.Values(defs.ScheduleID, defs.WorkflowID, "test-schedule-id")
@@ -195,6 +199,7 @@ func (s *QueryInterceptorSuite) TestValuesInterceptor_NoTransformation() {
 	vi := NewValuesInterceptor(
 		"test-namespace",
 		searchattribute.TestEsNameTypeMapWithScheduleID(),
+		nil,
 	)
 
 	values, err := vi.Values(defs.ScheduleID, defs.ScheduleID, "test-workflow-id")

common/persistence/visibility/store/elasticsearch/visibility_store_read_test.go

@@ -181,8 +181,8 @@ func (c *QueryConverter[ExprT]) Convert(
 	}
 
 	// If the query did not explicitly filter on TemporalNamespaceDivision,
-	// try setting the namespace division filter based on the archetype ID.
-	// Else, filter by null (no division).
+	// try setting the namespace division filter based on the archetype ID,
+	// else filter by null (no division).
 	var namespaceDivisionExpr ExprT
 	if !c.seenNamespaceDivision {
 		nsDivisionCol := NamespaceDivisionSAColumn()

common/persistence/visibility/store/query/converter.go

@@ -231,7 +231,8 @@ func (c *QueryConverterLegacy) convertSelectStmt(sel *sqlparser.Select) error {
 
 	// This logic comes from elasticsearch/visibility_store.go#convertQuery function.
 	// If the query did not explicitly filter on TemporalNamespaceDivision,
-	// handle it based on whether we have an archetype ID.
+	// try setting the namespace division filter based on the archetype ID,
+	// else filter by null (no division).
 	if !c.seenNamespaceDivision {
 		var namespaceDivisionExpr sqlparser.Expr
 		if c.archetypeID != chasm.UnspecifiedArchetypeID {

common/persistence/visibility/store/sql/query_converter_legacy.go

@@ -54,7 +54,7 @@ func (s *queryConverterSuite) SetupTest() {
 		&searchattribute.TestMapper{},
 		"",
 		nil,
-		0,
+		chasm.UnspecifiedArchetypeID,
 	)
 }
 

common/persistence/visibility/store/sql/query_converter_legacy_test.go

@@ -70,15 +70,15 @@ type (
 		RootRunID             string
 	}
 
-	// InternalListWorkflowExecutionsResponse is response from InternalListWorkflowExecutions
+	// InternalListWorkflowExecutionsResponse is response from ListWorkflowExecutions and ListChasmExecutions
 	InternalListWorkflowExecutionsResponse struct {
 		Executions []*InternalWorkflowExecutionInfo
 		// Token to read next page if there are more workflow executions beyond page size.
 		// Use this to set NextPageToken on ListWorkflowExecutionsRequest to read the next page.
 		NextPageToken []byte
 	}
 
-	// InternalGetWorkflowExecutionResponse is response from InternalGetWorkflowExecution
+	// InternalGetWorkflowExecutionResponse is response from GetWorkflowExecution
 	InternalGetWorkflowExecutionResponse struct {
 		Execution *InternalWorkflowExecutionInfo
 	}

common/persistence/visibility/store/visibility_store.go

@@ -5,10 +5,8 @@ import (
 	"errors"
 	"fmt"
 	"reflect"
-	"time"
 
 	commonpb "go.temporal.io/api/common/v1"
-
 	enumspb "go.temporal.io/api/enums/v1"
 	"go.temporal.io/api/serviceerror"
 	enumsspb "go.temporal.io/server/api/enums/v1"
@@ -659,20 +657,17 @@ func (e *ChasmEngine) ListExecutions(
 		Query:         request.Query,
 	}
 
+	if visReq.PageSize <= 0 {
+		visReq.PageSize = int(e.config.HistoryMaxPageSize(request.NamespaceName))
+	}
+
 	resp, err := e.visibilityMgr.ListChasmExecutions(ctx, visReq)
 	if err != nil {
 		return nil, err
 	}
 
-	// Convert manager.ListChasmExecutionsResponse to chasm.ListChasmRunsResponse
 	executions := make([]*chasm.ChasmExecutionInfo[*commonpb.Payload], len(resp.Executions))
 	for i, exec := range resp.Executions {
-		// Convert map[string]interface{} to SearchAttributesMap
-		chasmSAValues := make(map[string]chasm.VisibilityValue, len(exec.ChasmSearchAttributes))
-		for k, v := range exec.ChasmSearchAttributes {
-			chasmSAValues[k] = convertToVisibilityValue(v)
-		}
-
 		executions[i] = &chasm.ChasmExecutionInfo[*commonpb.Payload]{
 			BusinessID:             exec.BusinessID,
 			RunID:                  exec.RunID,
@@ -681,7 +676,7 @@ func (e *ChasmEngine) ListExecutions(
 			HistoryLength:          exec.HistoryLength,
 			HistorySizeBytes:       exec.HistorySizeBytes,
 			StateTransitionCount:   exec.StateTransitionCount,
-			ChasmSearchAttributes:  chasm.NewSearchAttributesMap(chasmSAValues),
+			ChasmSearchAttributes:  chasm.NewSearchAttributesMap(exec.ChasmSearchAttributes),
 			CustomSearchAttributes: exec.CustomSearchAttributes,
 			Memo:                   exec.Memo,
 			ChasmMemo:              exec.ChasmMemo,
@@ -717,29 +712,3 @@ func (e *ChasmEngine) CountExecutions(
 
 	return &chasm.CountChasmExecutionsResponse{Count: resp.Count}, nil
 }
-
-func convertToVisibilityValue(v interface{}) chasm.VisibilityValue {
-	switch val := v.(type) {
-	case int:
-		return chasm.VisibilityValueInt64(int64(val))
-	case int32:
-		return chasm.VisibilityValueInt64(int64(val))
-	case int64:
-		return chasm.VisibilityValueInt64(val)
-	case string:
-		return chasm.VisibilityValueString(val)
-	case bool:
-		return chasm.VisibilityValueBool(val)
-	case float64:
-		return chasm.VisibilityValueFloat64(val)
-	case time.Time:
-		return chasm.VisibilityValueTime(val)
-	case []byte:
-		return chasm.VisibilityValueByteSlice(val)
-	case []string:
-		return chasm.VisibilityValueStringSlice(val)
-	default:
-		// Return as string if type is unknown
-		return chasm.VisibilityValueString(fmt.Sprintf("%v", val))
-	}
-}