Remove query consistency level from request (#452)

alexshtin · web-flow · commit 8786f004f9f3 · 2020-06-13T18:20:42.000-07:00
diff --git a/Makefile b/Makefile
@@ -143,7 +143,7 @@ protoc: $(PROTO_OUT)
 	$(foreach PROTO_DIR,$(PROTO_DIRS),protoc --proto_path=$(PROTO_IMPORT) --gogoslick_out=Mgoogle/protobuf/wrappers.proto=github.com/gogo/protobuf/types,Mgoogle/protobuf/timestamp.proto=github.com/gogo/protobuf/types,plugins=grpc,paths=source_relative:$(PROTO_OUT) $(PROTO_DIR)*.proto$(NEWLINE))
 
 fix-proto-path:
-	mv -f $(PROTO_OUT)/server/* $(PROTO_OUT) && rm -d $(PROTO_OUT)/server
+	mv -f $(PROTO_OUT)/server/* $(PROTO_OUT) && rm -rf $(PROTO_OUT)/server
 
 # All gRPC generated service files pathes relative to PROTO_OUT.
 PROTO_GRPC_SERVICES = $(patsubst $(PROTO_OUT)/%,%,$(shell find $(PROTO_OUT) -name "service.pb.go"))
diff --git a/common/enums/defaults.go b/common/enums/defaults.go
@@ -45,11 +45,3 @@ func SetDefaultTaskListKind(f *enumspb.TaskListKind){
 		*f = enumspb.TASK_LIST_KIND_NORMAL
 	}
 }
-
-// TODO: remove this with corresponding field from request
-func SetDefaultQueryConsistencyLevel(f *enumspb.QueryConsistencyLevel){
-	if *f == enumspb.QUERY_CONSISTENCY_LEVEL_UNSPECIFIED{
-		*f = enumspb.QUERY_CONSISTENCY_LEVEL_STRONG
-	}
-}
-
diff --git a/common/service/dynamicconfig/constants.go b/common/service/dynamicconfig/constants.go
@@ -245,8 +245,6 @@ var keys = map[Key]string{
 	ReplicationTaskProcessorNoTaskInitialWait:              "history.ReplicationTaskProcessorNoTaskInitialWait",
 	ReplicationTaskProcessorCleanupInterval:                "history.ReplicationTaskProcessorCleanupInterval",
 	ReplicationTaskProcessorCleanupJitterCoefficient:       "history.ReplicationTaskProcessorCleanupJitterCoefficient",
-	EnableConsistentQuery:                                  "history.EnableConsistentQuery",
-	EnableConsistentQueryByNamespace:                       "history.EnableConsistentQueryByNamespace",
 	MaxBufferedQueryCount:                                  "history.MaxBufferedQueryCount",
 	MutableStateChecksumGenProbability:                     "history.mutableStateChecksumGenProbability",
 	MutableStateChecksumVerifyProbability:                  "history.mutableStateChecksumVerifyProbability",
@@ -741,10 +739,6 @@ const (
 	ReplicationTaskProcessorCleanupInterval
 	// ReplicationTaskProcessorCleanupJitterCoefficient is the jitter for cleanup timer
 	ReplicationTaskProcessorCleanupJitterCoefficient
-	// EnableConsistentQuery indicates if consistent query is enabled for the cluster
-	EnableConsistentQuery
-	// EnableConsistentQueryByNamespace indicates if consistent query is enabled for a namespace
-	EnableConsistentQueryByNamespace
 	// MaxBufferedQueryCount indicates the maximum number of queries which can be buffered at a given time for a single workflow
 	MaxBufferedQueryCount
 	// MutableStateChecksumGenProbability is the probability [0-100] that checksum will be generated for mutable state
diff --git a/config/dynamicconfig/development.yaml b/config/dynamicconfig/development.yaml
@@ -4,9 +4,6 @@ frontend.enableClientVersionCheck:
 system.minRetentionDays:
 - value: 0
   constraints: {}
-history.EnableConsistentQueryByNamespace:
-- value: true
-  constraints: {}
 history.persistenceMaxQPS:
 - value: 3000
   constraints: {}
diff --git a/go.mod b/go.mod
@@ -65,8 +65,8 @@ require (
 	github.com/urfave/cli v1.22.4
 	github.com/valyala/fastjson v1.5.1
 	github.com/xwb1989/sqlparser v0.0.0-20180606152119-120387863bf2
-	go.temporal.io/temporal v0.24.2
-	go.temporal.io/temporal-proto v0.24.2
+	go.temporal.io/temporal v0.24.3
+	go.temporal.io/temporal-proto v0.24.3
 	go.uber.org/atomic v1.6.0
 	go.uber.org/multierr v1.5.0
 	go.uber.org/zap v1.15.0
diff --git a/go.sum b/go.sum
@@ -67,8 +67,10 @@ github.com/cactus/go-statsd-client/statsd v0.0.0-20200423205355-cb0885a1018c/go.
 github.com/cch123/elasticsql v1.0.1 h1:B/c40hmj/TxqjLrpry565J+poi0S2b2NjGOUWmyI+2Q=
 github.com/cch123/elasticsql v1.0.1/go.mod h1:x1Ew690FkNjGn9Fm0asmEqZcteTgx+q3CSwlci8SteQ=
 github.com/census-instrumentation/opencensus-proto v0.2.1/go.mod h1:f6KPmirojxKA12rnyqOA5BBL4O983OfeGPqjHWSTneU=
+github.com/chzyer/logex v1.1.10 h1:Swpa1K6QvQznwJRcfTfQJmTE72DqScAa40E+fbHEXEE=
 github.com/chzyer/logex v1.1.10/go.mod h1:+Ywpsq7O8HXn0nuIou7OrIPyXbp3wmkHB+jjWRnGsAI=
 github.com/chzyer/readline v0.0.0-20180603132655-2972be24d48e/go.mod h1:nSuG5e5PlCu98SY8svDHJxuZscDgtXS6KTTbou5AhLI=
+github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1 h1:q763qf9huN11kDQavWsoZXJNW3xEE4JJyHa5Q25/sd8=
 github.com/chzyer/test v0.0.0-20180213035817-a1ea475d72b1/go.mod h1:Q3SI9o4m/ZMnBNeIyt5eFwwo7qiLfzFZmjNmxjkiQlU=
 github.com/client9/misspell v0.3.4/go.mod h1:qj6jICC3Q7zFZvVWo7KLAzC3yx5G7kyvSDkc90ppPyw=
 github.com/cncf/udpa/go v0.0.0-20191209042840-269d4d468f6f/go.mod h1:M8M6+tZqaGXZJjfX53e64911xZQV5JYwmTeXPW+k8Sc=
@@ -336,10 +338,10 @@ go.opencensus.io v0.22.0/go.mod h1:+kGneAE2xo2IficOXnaByMWTGM9T73dGwxeWcUqIpI8=
 go.opencensus.io v0.22.2/go.mod h1:yxeiOL68Rb0Xd1ddK5vPZ/oVn4vY4Ynel7k9FzqtOIw=
 go.opencensus.io v0.22.3 h1:8sGtKOrtQqkN1bp2AtX+misvLIlOmsEsNd+9NIcPEm8=
 go.opencensus.io v0.22.3/go.mod h1:yxeiOL68Rb0Xd1ddK5vPZ/oVn4vY4Ynel7k9FzqtOIw=
-go.temporal.io/temporal v0.24.2 h1:bNcactYPNM67xhfvGhUGDjnx5JjXqdRpIWuU0gIKSlI=
-go.temporal.io/temporal v0.24.2/go.mod h1:/2xoMEwehz59QdXFZvfL06hvNeiwgl8yxjl2dOHMZiQ=
-go.temporal.io/temporal-proto v0.24.2 h1:XZRX9+kB63jn6crfst2Sth3r8scabEqoXksUQu3q91k=
-go.temporal.io/temporal-proto v0.24.2/go.mod h1:upayz+pnLT5z2lzh/qktmSnouTTl+WYcjbMoejagmzU=
+go.temporal.io/temporal v0.24.3 h1:BfX2+Eha2Y3J05VEXsCSruZVvKUbkg6FwCadYkeJPFU=
+go.temporal.io/temporal v0.24.3/go.mod h1:6kIYe+aO3Glb5RfBSZOyc95niiWm4dZZpfXZlkxqq9A=
+go.temporal.io/temporal-proto v0.24.3 h1:ZTmKRv0f1JFYEte5fNzER24qujSd+qHs4wKAVuTv4e0=
+go.temporal.io/temporal-proto v0.24.3/go.mod h1:upayz+pnLT5z2lzh/qktmSnouTTl+WYcjbMoejagmzU=
 go.uber.org/atomic v1.5.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
 go.uber.org/atomic v1.6.0 h1:Ezj3JGmsOnG1MoRWQkPBsKLe9DwWD9QeXzTRzzldNVk=
 go.uber.org/atomic v1.6.0/go.mod h1:sABNBOSYdrvTF6hTgEIbc7YasKWGhgEQZyfxyTvoXHQ=
diff --git a/host/dynamicconfig.go b/host/dynamicconfig.go
@@ -47,7 +47,6 @@ var (
 		dynamicconfig.ReplicationTaskFetcherAggregationInterval:     200 * time.Millisecond,
 		dynamicconfig.ReplicationTaskFetcherErrorRetryWait:          50 * time.Millisecond,
 		dynamicconfig.ReplicationTaskProcessorErrorRetryWait:        time.Millisecond,
-		dynamicconfig.EnableConsistentQueryByNamespace:              true,
 	}
 )
 
diff --git a/host/queryworkflow_test.go b/host/queryworkflow_test.go
@@ -26,6 +26,7 @@ package host
 
 import (
 	"bytes"
+	"context"
 	"encoding/binary"
 	"errors"
 	"strconv"
@@ -45,7 +46,6 @@ import (
 	"github.com/temporalio/temporal/common/log/tag"
 	"github.com/temporalio/temporal/common/payloads"
 	"github.com/temporalio/temporal/common/rpc"
-	"github.com/temporalio/temporal/service/history"
 )
 
 func (s *integrationSuite) TestQueryWorkflow_Sticky() {
@@ -687,7 +687,6 @@ func (s *integrationSuite) TestQueryWorkflow_Consistent_PiggybackQuery() {
 				QueryType: queryType,
 			},
 			QueryRejectCondition:  rejectCondition,
-			QueryConsistencyLevel: enumspb.QUERY_CONSISTENCY_LEVEL_STRONG,
 		})
 		// after the query is answered the signal is handled because query is consistent and since
 		// signal came before query signal must be handled by the time query returns
@@ -869,7 +868,6 @@ func (s *integrationSuite) TestQueryWorkflow_Consistent_Timeout() {
 				QueryType: queryType,
 			},
 			QueryRejectCondition:  rejectCondition,
-			QueryConsistencyLevel: enumspb.QUERY_CONSISTENCY_LEVEL_STRONG,
 		})
 		cancel()
 		queryResultCh <- QueryResult{Resp: queryResp, Err: err}
@@ -1031,7 +1029,6 @@ func (s *integrationSuite) TestQueryWorkflow_Consistent_BlockedByStarted_NonStic
 				QueryType: queryType,
 			},
 			QueryRejectCondition:  rejectCondition,
-			QueryConsistencyLevel: enumspb.QUERY_CONSISTENCY_LEVEL_STRONG,
 		})
 		s.True(handledSignal.Load())
 		queryResultCh <- QueryResult{Resp: queryResp, Err: err}
@@ -1221,7 +1218,6 @@ func (s *integrationSuite) TestQueryWorkflow_Consistent_NewDecisionTask_Sticky()
 				QueryType: queryType,
 			},
 			QueryRejectCondition:  rejectCondition,
-			QueryConsistencyLevel: enumspb.QUERY_CONSISTENCY_LEVEL_STRONG,
 		})
 		s.True(handledSignal.Load())
 		queryResultCh <- QueryResult{Resp: queryResp, Err: err}
@@ -1342,15 +1338,16 @@ func (s *integrationSuite) TestQueryWorkflow_BeforeFirstDecision() {
 		RunId:      we.RunId,
 	}
 
-	// query workflow without any decision task should produce an error
-	queryResp, err := s.engine.QueryWorkflow(NewContext(), &workflowservice.QueryWorkflowRequest{
+	// query workflow without any decision task should timeout
+	ctx, cancel := context.WithTimeout(NewContext(), 1 * time.Second)
+	defer cancel()
+	queryResp, err := s.engine.QueryWorkflow(ctx, &workflowservice.QueryWorkflowRequest{
 		Namespace: s.namespace,
 		Execution: workflowExecution,
 		Query: &querypb.WorkflowQuery{
 			QueryType: queryType,
 		},
-		QueryConsistencyLevel: enumspb.QUERY_CONSISTENCY_LEVEL_EVENTUAL,
 	})
 	s.IsType(&workflowservice.QueryWorkflowResponse{}, queryResp)
-	s.IsType(history.ErrQueryWorkflowBeforeFirstDecision, err)
+	s.IsType(&serviceerror.DeadlineExceeded{}, err)
 }
diff --git a/proto/internal/server/adminservice/v1/request_response.proto b/proto/internal/server/adminservice/v1/request_response.proto
@@ -170,7 +170,7 @@ message DescribeClusterRequest {
 }
 
 message DescribeClusterResponse {
-    temporal.version.v1.SupportedClientVersions supported_client_versions = 1;
+    temporal.version.v1.SupportedSDKVersions supported_client_versions = 1;
     server.cluster.v1.MembershipInfo membership_info = 2;
 }
 
diff --git a/proto/temporal-proto b/proto/temporal-proto
@@ -1 +1 @@
-Subproject commit 4888bc3b25e40a4246a33919d55e3b5ac9af0a93
+Subproject commit 496da20ef6d6102fa3e2bef8238c60a5e0688d43
diff --git a/service/frontend/adminHandler.go b/service/frontend/adminHandler.go
@@ -629,7 +629,7 @@ func (adh *AdminHandler) DescribeCluster(ctx context.Context, _ *adminservice.De
 	}
 
 	return &adminservice.DescribeClusterResponse{
-		SupportedClientVersions: &versionpb.SupportedClientVersions{
+		SupportedClientVersions: &versionpb.SupportedSDKVersions{
 			GoSdk:   headers.SupportedGoSDKVersion,
 			JavaSdk: headers.SupportedJavaSDKVersion,
 		},
diff --git a/service/frontend/dcRedirectionHandler.go b/service/frontend/dcRedirectionHandler.go
@@ -565,7 +565,8 @@ func (handler *DCRedirectionHandlerImpl) QueryWorkflow(
 			// Only autofoward consistent queries, this is done for two reasons:
 			// 1. Query is meant to be fast, autoforwarding all queries will increase latency.
 			// 2. If eventual consistency was requested then the results from running out of local dc will be fine.
-			if request.GetQueryConsistencyLevel() == enumspb.QUERY_CONSISTENCY_LEVEL_STRONG {
+			queryConsistencyLevel := enumspb.QUERY_CONSISTENCY_LEVEL_STRONG
+			if queryConsistencyLevel == enumspb.QUERY_CONSISTENCY_LEVEL_STRONG {
 				remoteClient := handler.GetRemoteFrontendClient(targetDC)
 				resp, err = remoteClient.QueryWorkflow(ctx, request)
 			} else {
diff --git a/service/frontend/dcRedirectionHandler_test.go b/service/frontend/dcRedirectionHandler_test.go
@@ -32,19 +32,17 @@ import (
 	"github.com/stretchr/testify/mock"
 	"github.com/stretchr/testify/require"
 	"github.com/stretchr/testify/suite"
-	enumspb "go.temporal.io/temporal-proto/enums/v1"
 	tasklistpb "go.temporal.io/temporal-proto/tasklist/v1"
 	"go.temporal.io/temporal-proto/workflowservice/v1"
 	"go.temporal.io/temporal-proto/workflowservicemock/v1"
+	healthpb "google.golang.org/grpc/health/grpc_health_v1"
 
 	tokengenpb "github.com/temporalio/temporal/.gen/proto/token/v1"
 	"github.com/temporalio/temporal/common/cluster"
 	"github.com/temporalio/temporal/common/metrics"
 	"github.com/temporalio/temporal/common/resource"
 	"github.com/temporalio/temporal/common/service/config"
 	"github.com/temporalio/temporal/common/service/dynamicconfig"
-
-	healthpb "google.golang.org/grpc/health/grpc_health_v1"
 )
 
 type (
@@ -384,7 +382,6 @@ func (s *dcRedirectionHandlerSuite) TestQueryWorkflow() {
 
 	req := &workflowservice.QueryWorkflowRequest{
 		Namespace:             s.namespace,
-		QueryConsistencyLevel: enumspb.QUERY_CONSISTENCY_LEVEL_STRONG,
 	}
 	resp, err := s.handler.QueryWorkflow(context.Background(), req)
 	s.Nil(err)
diff --git a/service/frontend/workflowHandler.go b/service/frontend/workflowHandler.go
@@ -2854,7 +2854,7 @@ func (wh *WorkflowHandler) RespondQueryTaskCompleted(ctx context.Context, reques
 
 	headers := headers.GetValues(ctx, headers.ClientImplHeaderName, headers.ClientFeatureVersionHeaderName)
 	request.WorkerVersionInfo = &versionpb.WorkerVersionInfo{
-		Impl:           headers[0],
+		Implementation: headers[0],
 		FeatureVersion: headers[1],
 	}
 	matchingRequest := &matchingservice.RespondQueryTaskCompletedRequest{
@@ -2957,8 +2957,6 @@ func (wh *WorkflowHandler) QueryWorkflow(ctx context.Context, request *workflows
 		return nil, wh.error(errQueryTypeNotSet, scope)
 	}
 
-	enums.SetDefaultQueryConsistencyLevel(&request.QueryConsistencyLevel)
-
 	namespaceID, err := wh.GetNamespaceCache().GetNamespaceID(request.GetNamespace())
 	if err != nil {
 		return nil, wh.error(err, scope)
@@ -3079,7 +3077,7 @@ func (wh *WorkflowHandler) DescribeTaskList(ctx context.Context, request *workfl
 		return nil, err
 	}
 
-	if request.GetTaskListType() == enumspb.TASK_LIST_TYPE_UNSPECIFIED{
+	if request.GetTaskListType() == enumspb.TASK_LIST_TYPE_UNSPECIFIED {
 		return nil, wh.error(errTaskListTypeNotSet, scope)
 	}
 
@@ -3114,7 +3112,7 @@ func (wh *WorkflowHandler) GetClusterInfo(ctx context.Context, _ *workflowservic
 	}
 
 	return &workflowservice.GetClusterInfoResponse{
-		SupportedClientVersions: &versionpb.SupportedClientVersions{
+		SupportedSdkVersions: &versionpb.SupportedSDKVersions{
 			GoSdk:   headers.SupportedGoSDKVersion,
 			JavaSdk: headers.SupportedJavaSDKVersion,
 		},
diff --git a/service/history/historyEngine.go b/service/history/historyEngine.go
@@ -198,8 +198,6 @@ var (
 	ErrQueryEnteredInvalidState = serviceerror.NewInvalidArgument("query entered invalid state, this should be impossible")
 	// ErrQueryWorkflowBeforeFirstDecision is error indicating that query was attempted before first decision task completed
 	ErrQueryWorkflowBeforeFirstDecision = serviceerror.NewQueryFailed("workflow must handle at least one decision task before it can be queried")
-	// ErrConsistentQueryNotEnabled is error indicating that consistent query was requested but either cluster or namespace does not enable consistent query
-	ErrConsistentQueryNotEnabled = serviceerror.NewInvalidArgument("cluster or namespace does not enable strongly consistent query but strongly consistent query was requested")
 	// ErrConsistentQueryBufferExceeded is error indicating that too many consistent queries have been buffered and until buffered queries are finished new consistent queries cannot be buffered
 	ErrConsistentQueryBufferExceeded = serviceerror.NewInternal("consistent query buffer is full, cannot accept new consistent queries")
 
@@ -825,10 +823,7 @@ func (e *historyEngineImpl) QueryWorkflow(
 
 	scope := e.metricsClient.Scope(metrics.HistoryQueryWorkflowScope)
 
-	consistentQueryEnabled := e.config.EnableConsistentQuery() && e.config.EnableConsistentQueryByNamespace(request.GetRequest().GetNamespace())
-	if request.GetRequest().GetQueryConsistencyLevel() == enumspb.QUERY_CONSISTENCY_LEVEL_STRONG && !consistentQueryEnabled {
-		return nil, ErrConsistentQueryNotEnabled
-	}
+	queryConsistencyLevel := enumspb.QUERY_CONSISTENCY_LEVEL_STRONG
 
 	mutableStateResp, err := e.getMutableState(ctx, request.GetNamespaceId(), *request.GetRequest().GetExecution())
 	if err != nil {
@@ -850,7 +845,7 @@ func (e *historyEngineImpl) QueryWorkflow(
 		}
 	}
 
-	if request.GetRequest().GetQueryConsistencyLevel() == enumspb.QUERY_CONSISTENCY_LEVEL_EVENTUAL {
+	if queryConsistencyLevel == enumspb.QUERY_CONSISTENCY_LEVEL_EVENTUAL {
 		// query cannot be processed unless at least one decision task has finished
 		// if first decision task has not finished wait for up to a second for it to complete
 		queryFirstDecisionTaskWaitTime := defaultQueryFirstDecisionTaskWaitTime
@@ -904,7 +899,7 @@ func (e *historyEngineImpl) QueryWorkflow(
 	// 4. if there is no pending or started decision it means no events came before query arrived, so its safe to dispatch directly
 	safeToDispatchDirectly := !de.IsNamespaceActive() ||
 		!mutableState.IsWorkflowExecutionRunning() ||
-		req.GetQueryConsistencyLevel() == enumspb.QUERY_CONSISTENCY_LEVEL_EVENTUAL ||
+		queryConsistencyLevel == enumspb.QUERY_CONSISTENCY_LEVEL_EVENTUAL ||
 		(!mutableState.HasPendingDecision() && !mutableState.HasInFlightDecision())
 	if safeToDispatchDirectly {
 		release(nil)
diff --git a/service/history/historyEngine_test.go b/service/history/historyEngine_test.go
diff --git a/service/history/service.go b/service/history/service.go
diff --git a/tools/cli/flags.go b/tools/cli/flags.go
diff --git a/tools/cli/workflowCommands.go b/tools/cli/workflowCommands.go

Original file line number	Diff line number	Diff line change
`@@ -45,11 +45,3 @@ func SetDefaultTaskListKind(f *enumspb.TaskListKind){`
`45`	`45`	`*f = enumspb.TASK_LIST_KIND_NORMAL`
`46`	`46`	`}`
`47`	`47`	`}`
`48`		`-`
`49`		`-// TODO: remove this with corresponding field from request`
`50`		`-func SetDefaultQueryConsistencyLevel(f *enumspb.QueryConsistencyLevel){`
`51`		`- if *f == enumspb.QUERY_CONSISTENCY_LEVEL_UNSPECIFIED{`
`52`		`- *f = enumspb.QUERY_CONSISTENCY_LEVEL_STRONG`
`53`		`- }`
`54`		`-}`
`55`		`-`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,6 @@ var (`
`47`	`47`	`dynamicconfig.ReplicationTaskFetcherAggregationInterval: 200 * time.Millisecond,`
`48`	`48`	`dynamicconfig.ReplicationTaskFetcherErrorRetryWait: 50 * time.Millisecond,`
`49`	`49`	`dynamicconfig.ReplicationTaskProcessorErrorRetryWait: time.Millisecond,`
`50`		`- dynamicconfig.EnableConsistentQueryByNamespace: true,`
`51`	`50`	`}`
`52`	`51`	`)`
`53`	`52`
Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,7 @@ message DescribeClusterRequest {`
`170`	`170`	`}`
`171`	`171`
`172`	`172`	`message DescribeClusterResponse {`
`173`		`- temporal.version.v1.SupportedClientVersions supported_client_versions = 1;`
	`173`	`+ temporal.version.v1.SupportedSDKVersions supported_client_versions = 1;`
`174`	`174`	`server.cluster.v1.MembershipInfo membership_info = 2;`
`175`	`175`	`}`
`176`	`176`