Set ParentClosePolicy default value (#481)

Author: alexshtin

common/enums/defaults.go

@@ -45,3 +45,9 @@ func SetDefaultTaskQueueKind(f *enumspb.TaskQueueKind) {
 		*f = enumspb.TASK_QUEUE_KIND_NORMAL
 	}
 }
+
+func SetDefaultParentClosePolicy(f *enumspb.ParentClosePolicy) {
+	if *f == enumspb.PARENT_CLOSE_POLICY_UNSPECIFIED {
+		*f = enumspb.PARENT_CLOSE_POLICY_TERMINATE
+	}
+}

service/history/decisionTaskHandler.go

@@ -38,6 +38,7 @@ import (
 	"github.com/temporalio/temporal/common"
 	"github.com/temporalio/temporal/common/backoff"
 	"github.com/temporalio/temporal/common/cache"
+	"github.com/temporalio/temporal/common/enums"
 	"github.com/temporalio/temporal/common/log"
 	"github.com/temporalio/temporal/common/log/tag"
 	"github.com/temporalio/temporal/common/metrics"
@@ -761,10 +762,14 @@ func (handler *decisionTaskHandlerImpl) handleDecisionStartChildWorkflow(
 	}
 
 	enabled := handler.config.EnableParentClosePolicy(handler.namespaceEntry.GetInfo().Name)
-	if !enabled {
+	if enabled {
+		enums.SetDefaultParentClosePolicy(&attr.ParentClosePolicy)
+	} else {
 		attr.ParentClosePolicy = enumspb.PARENT_CLOSE_POLICY_ABANDON
 	}
 
+	enums.SetDefaultWorkflowIdReusePolicy(&attr.WorkflowIdReusePolicy)
+
 	requestID := uuid.New()
 	_, _, err = handler.mutableState.AddStartChildWorkflowExecutionInitiatedEvent(
 		handler.decisionTaskCompletedID, requestID, attr,

service/history/historyEngine.go

@@ -2852,7 +2852,7 @@ func (e *historyEngineImpl) applyWorkflowIDReusePolicyHelper(
 		msg := "Workflow execution already finished. WorkflowId: %v, RunId: %v. Workflow Id reuse policy: reject duplicate workflow Id."
 		return getWorkflowAlreadyStartedError(msg, prevStartRequestID, execution.GetWorkflowId(), prevRunID)
 	default:
-		return serviceerror.NewInternal("Failed to process start workflow reuse policy.")
+		return serviceerror.NewInternal(fmt.Sprintf("Failed to process start workflow reuse policy: %v.", wfIDReusePolicy))
 	}
 
 	return nil