Skip to content

Commit acb96fd

Browse files
authored
Adds ExecutionInfo reference to InternalWorkflowMutation #2530
This enables the underlying store to have access to the ExecutionInfo on the Mutation object without having to do deserialization
1 parent 4d06e1a commit acb96fd

File tree

5 files changed

+7
-5
lines changed

5 files changed

+7
-5
lines changed

common/persistence/cassandra/util.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ func applyWorkflowMutationBatch(
5454
namespaceID,
5555
workflowID,
5656
runID,
57-
workflowMutation.ExecutionInfo,
57+
workflowMutation.ExecutionInfoBlob,
5858
workflowMutation.ExecutionState,
5959
workflowMutation.ExecutionStateBlob,
6060
workflowMutation.NextEventID,

common/persistence/execution_manager.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -478,6 +478,7 @@ func (m *executionManagerImpl) SerializeWorkflowMutation(
478478
UpsertRequestCancelInfos: make(map[int64]*commonpb.DataBlob),
479479
UpsertSignalInfos: make(map[int64]*commonpb.DataBlob),
480480

481+
ExecutionInfo: input.ExecutionInfo,
481482
ExecutionState: input.ExecutionState,
482483

483484
DeleteActivityInfos: input.DeleteActivityInfos,
@@ -500,7 +501,7 @@ func (m *executionManagerImpl) SerializeWorkflowMutation(
500501
NextEventID: input.NextEventID,
501502
}
502503

503-
result.ExecutionInfo, err = m.serializer.WorkflowExecutionInfoToBlob(input.ExecutionInfo, enumspb.ENCODING_TYPE_PROTO3)
504+
result.ExecutionInfoBlob, err = m.serializer.WorkflowExecutionInfoToBlob(input.ExecutionInfo, enumspb.ENCODING_TYPE_PROTO3)
504505
if err != nil {
505506
return nil, err
506507
}

common/persistence/persistenceInterface.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,8 @@ type (
388388
WorkflowID string
389389
RunID string
390390

391-
ExecutionInfo *commonpb.DataBlob
391+
ExecutionInfo *persistencespb.WorkflowExecutionInfo
392+
ExecutionInfoBlob *commonpb.DataBlob
392393
ExecutionState *persistencespb.WorkflowExecutionState
393394
ExecutionStateBlob *commonpb.DataBlob
394395
NextEventID int64

common/persistence/size.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -104,7 +104,7 @@ func statusOfInternalWorkflowMutation(
104104
return nil
105105
}
106106

107-
executionInfoSize := sizeOfBlob(mutation.ExecutionInfo)
107+
executionInfoSize := sizeOfBlob(mutation.ExecutionInfoBlob)
108108
executionStateSize := sizeOfBlob(mutation.ExecutionStateBlob)
109109

110110
activityInfoCount := len(mutation.UpsertActivityInfos)

common/persistence/sql/execution_util.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ func applyWorkflowMutationTx(
8686
tx,
8787
namespaceID,
8888
workflowID,
89-
workflowMutation.ExecutionInfo,
89+
workflowMutation.ExecutionInfoBlob,
9090
workflowMutation.ExecutionState,
9191
workflowMutation.NextEventID,
9292
lastWriteVersion,

0 commit comments

Comments
 (0)