Client error log level (#2701)

yiminc · web-flow · commit bcf9e57a0bdc · 2022-04-11T15:05:03.000-07:00
diff --git a/client/history/metricClient.go b/client/history/metricClient.go
@@ -635,7 +635,7 @@ func (c *metricClient) finishMetricsRecording(
 			*serviceerror.WorkflowExecutionAlreadyStarted:
 			// noop - not interest and too many logs
 		default:
-			c.throttledLogger.Error("history client encountered error", tag.Error(err), tag.ErrorType(err))
+			c.throttledLogger.Info("history client encountered error", tag.Error(err), tag.ErrorType(err))
 		}
 		scope.Tagged(metrics.ServiceErrorTypeTag(err)).IncCounter(metrics.ClientFailures)
 	}
diff --git a/client/matching/metricClient.go b/client/matching/metricClient.go
@@ -265,7 +265,7 @@ func (c *metricClient) finishMetricsRecording(
 			// noop - not interest and too many logs
 		default:
 
-			c.throttledLogger.Error("matching client encountered error", tag.Error(err), tag.ErrorType(err))
+			c.throttledLogger.Info("matching client encountered error", tag.Error(err), tag.ErrorType(err))
 		}
 		scope.Tagged(metrics.ServiceErrorTypeTag(err)).IncCounter(metrics.ClientFailures)
 	}

Original file line number	Diff line number	Diff line change
`@@ -635,7 +635,7 @@ func (c *metricClient) finishMetricsRecording(`
`635`	`635`	`*serviceerror.WorkflowExecutionAlreadyStarted:`
`636`	`636`	`// noop - not interest and too many logs`
`637`	`637`	`default:`
`638`		`- c.throttledLogger.Error("history client encountered error", tag.Error(err), tag.ErrorType(err))`
	`638`	`+ c.throttledLogger.Info("history client encountered error", tag.Error(err), tag.ErrorType(err))`
`639`	`639`	`}`
`640`	`640`	`scope.Tagged(metrics.ServiceErrorTypeTag(err)).IncCounter(metrics.ClientFailures)`
`641`	`641`	`}`
Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ func (c *metricClient) finishMetricsRecording(`
`265`	`265`	`// noop - not interest and too many logs`
`266`	`266`	`default:`
`267`	`267`
`268`		`- c.throttledLogger.Error("matching client encountered error", tag.Error(err), tag.ErrorType(err))`
	`268`	`+ c.throttledLogger.Info("matching client encountered error", tag.Error(err), tag.ErrorType(err))`
`269`	`269`	`}`
`270`	`270`	`scope.Tagged(metrics.ServiceErrorTypeTag(err)).IncCounter(metrics.ClientFailures)`
`271`	`271`	`}`