Skip to content

Commit c2056ba

Browse files
authored
Adds templatization for gRPC and membership ports exposed by Temporal #905
What changed? Enables ability to set gRPC/membership ports via environment variables when launching a Docker container. Why? To be able to configure ports with environment variables. How did you test it? Tested using dockerize command locally. Potential risks N/A
1 parent e8598ab commit c2056ba

File tree

1 file changed

+12
-10
lines changed

1 file changed

+12
-10
lines changed

docker/config_template.yaml

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -168,11 +168,13 @@ global:
168168
- {{ default .Env.TEMPORAL_TLS_SERVER_CA_CERT "" }}
169169
rootCaData:
170170
- {{ default .Env.TEMPORAL_TLS_SERVER_CA_CERT_DATA "" }}
171+
172+
{{- $temporalGrpcPort := default .Env.FRONTEND_GRPC_PORT "7233" -}}
171173
services:
172174
frontend:
173175
rpc:
174-
grpcPort: 7233
175-
membershipPort: 6933
176+
grpcPort: {{ $temporalGrpcPort }}
177+
membershipPort: {{ default .Env.FRONTEND_MEMBERSHIP_PORT "6933" }}
176178
bindOnIP: {{ default .Env.BIND_ON_IP "127.0.0.1" }}
177179
{{- if .Env.STATSD_ENDPOINT }}
178180
metrics:
@@ -188,8 +190,8 @@ services:
188190

189191
matching:
190192
rpc:
191-
grpcPort: 7235
192-
membershipPort: 6935
193+
grpcPort: {{ default .Env.MATCHING_GRPC_PORT "7235" }}
194+
membershipPort: {{ default .Env.MATCHING_MEMBERSHIP_PORT "6935" }}
193195
bindOnIP: {{ default .Env.BIND_ON_IP "127.0.0.1" }}
194196
{{- if .Env.STATSD_ENDPOINT }}
195197
metrics:
@@ -205,8 +207,8 @@ services:
205207

206208
history:
207209
rpc:
208-
grpcPort: 7234
209-
membershipPort: 6934
210+
grpcPort: {{ default .Env.HISTORY_GRPC_PORT "7234" }}
211+
membershipPort: {{ default .Env.HISTORY_MEMBERSHIP_PORT "6934" }}
210212
bindOnIP: {{ default .Env.BIND_ON_IP "127.0.0.1" }}
211213
{{- if .Env.STATSD_ENDPOINT }}
212214
metrics:
@@ -222,8 +224,8 @@ services:
222224

223225
worker:
224226
rpc:
225-
grpcPort: 7239
226-
membershipPort: 6939
227+
grpcPort: {{ default .Env.WORKER_GRPC_PORT "7239" }}
228+
membershipPort: {{ default .Env.WORKER_MEMBERSHIP_PORT "6939" }}
227229
bindOnIP: {{ default .Env.BIND_ON_IP "127.0.0.1" }}
228230
{{- if .Env.STATSD_ENDPOINT }}
229231
metrics:
@@ -247,7 +249,7 @@ clusterMetadata:
247249
enabled: true
248250
initialFailoverVersion: 1
249251
rpcName: "frontend"
250-
rpcAddress: "127.0.0.1:7233"
252+
rpcAddress: {{ (print "127.0.0.1:" $temporalGrpcPort) }}
251253

252254
dcRedirectionPolicy:
253255
policy: "noop"
@@ -296,7 +298,7 @@ kafka:
296298
dlq-topic: temporal-visibility-dev-dlq
297299

298300
{{ $publicIp := default .Env.BIND_ON_IP "127.0.0.1" -}}
299-
{{- $defaultPublicHostPost := (print $publicIp ":7233") -}}
301+
{{- $defaultPublicHostPost := (print $publicIp ":" $temporalGrpcPort) -}}
300302
publicClient:
301303
hostPort: {{ default .Env.PUBLIC_FRONTEND_ADDRESS $defaultPublicHostPost }}
302304

0 commit comments

Comments
 (0)