Align dynamic config with proto enum (#417)

Author: alexshtin

common/definition/indexedKeys.go

@@ -47,8 +47,8 @@ const (
 	CustomStringField     = "CustomStringField"
 	CustomKeywordField    = "CustomKeywordField"
 	CustomIntField        = "CustomIntField"
-	CustomBoolField       = "CustomBoolField"
 	CustomDoubleField     = "CustomDoubleField"
+	CustomBoolField       = "CustomBoolField"
 	CustomDatetimeField   = "CustomDatetimeField"
 	TemporalChangeVersion = "TemporalChangeVersion"
 )
@@ -69,8 +69,8 @@ func createDefaultIndexedKeys() map[string]interface{} {
 		CustomStringField:     commonpb.IndexedValueType_String,
 		CustomKeywordField:    commonpb.IndexedValueType_Keyword,
 		CustomIntField:        commonpb.IndexedValueType_Int,
-		CustomBoolField:       commonpb.IndexedValueType_Bool,
 		CustomDoubleField:     commonpb.IndexedValueType_Double,
+		CustomBoolField:       commonpb.IndexedValueType_Bool,
 		CustomDatetimeField:   commonpb.IndexedValueType_Datetime,
 		TemporalChangeVersion: commonpb.IndexedValueType_Keyword,
 		BinaryChecksums:       commonpb.IndexedValueType_Keyword,

common/elasticsearch/validator/searchAttrValidator.go

@@ -98,7 +98,7 @@ func (sv *SearchAttributesValidator) ValidateSearchAttributes(input *commonpb.Se
 
 			sv.logger.WithTags(tag.ESKey(key), tag.Value(invalidValue), tag.WorkflowNamespace(namespace)).
 				Error("invalid search attribute value")
-			return serviceerror.NewInvalidArgument(fmt.Sprintf("%s is not a valid search attribute value for key %s", invalidValue, key))
+			return serviceerror.NewInvalidArgument(fmt.Sprintf("%v is not a valid search attribute value for key %s", invalidValue, key))
 		}
 		// verify: key is not system reserved
 		if definition.IsSystemIndexedKey(key) {

config/dynamicconfig/development_es.yaml

@@ -19,8 +19,8 @@ frontend.validSearchAttributes:
       CustomStringField: 0
       CustomKeywordField: 1
       CustomIntField: 2
-      CustomBoolField: 3
-      CustomDoubleField: 4
+      CustomDoubleField: 3
+      CustomBoolField: 4
       CustomDatetimeField: 5
       project: 1
       service: 1

host/testdata/es_index_template.json

@@ -49,8 +49,8 @@
             "CustomStringField":  { "type": "text" },
             "CustomKeywordField": { "type": "keyword"},
             "CustomIntField": { "type": "long"},
-            "CustomBoolField": { "type": "boolean"},
             "CustomDoubleField": { "type": "double"},
+            "CustomBoolField": { "type": "boolean"},
             "CustomDatetimeField": { "type": "date"},
             "project": { "type": "keyword"},
             "service": { "type": "keyword"},

schema/elasticsearch/visibility/index_template.json

@@ -52,8 +52,8 @@
             "CustomStringField":  { "type": "text" },
             "CustomKeywordField": { "type": "keyword"},
             "CustomIntField": { "type": "long"},
-            "CustomBoolField": { "type": "boolean"},
             "CustomDoubleField": { "type": "double"},
+            "CustomBoolField": { "type": "boolean"},
             "CustomDatetimeField": { "type": "date"},
             "project": { "type": "keyword"},
             "service": { "type": "keyword"},