You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hello! I just wanted to give you all a heads up that you might want to update the pybind11 that's packaged with taco. The version of pybind11 you've included has some problems when they search for python and can sometimes target the wrong python version (which happened to me when I tried to make the python bindings for taco). You can check out this pybind11 issue (pybind/pybind11/issues/1090) and PR (pybind/pybind11/pull/2370) for more details.
PyBind should actually be a git sub-module. PR #400 will address this and will be removed from draft once I figure out why one of the unit tests fail.
Edit: I have removed the PR from draft so now pybind11 will hopefully be a git submodule if there are no objections. I currently use v2.6 which seems like the latest stable release. It should be easier for us to update pybind in the future now as well :)
Problem
Hello! I just wanted to give you all a heads up that you might want to update the
pybind11
that's packaged withtaco
. The version ofpybind11
you've included has some problems when they search for python and can sometimes target the wrong python version (which happened to me when I tried to make the python bindings fortaco
). You can check out thispybind11
issue (pybind/pybind11/issues/1090) and PR (pybind/pybind11/pull/2370) for more details.Version Info
Solution
Updating to the latest version of
pybind11
fixed this for me.Happy to make a PR for this if that'd be helpful.
The text was updated successfully, but these errors were encountered: