Skip to content

Old version of Pybind11 find the wrong python version #397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jamesETsmith opened this issue Feb 4, 2021 · 1 comment
Closed

Old version of Pybind11 find the wrong python version #397

jamesETsmith opened this issue Feb 4, 2021 · 1 comment

Comments

@jamesETsmith
Copy link

Problem

Hello! I just wanted to give you all a heads up that you might want to update the pybind11 that's packaged with taco. The version of pybind11 you've included has some problems when they search for python and can sometimes target the wrong python version (which happened to me when I tried to make the python bindings for taco). You can check out this pybind11 issue (pybind/pybind11/issues/1090) and PR (pybind/pybind11/pull/2370) for more details.

Version Info

  • Taco: 1114197
  • CC/CXX: gcc 10.2
  • Python 3.9.1

Solution

Updating to the latest version of pybind11 fixed this for me.

Happy to make a PR for this if that'd be helpful.

@rawnhenry
Copy link
Collaborator

rawnhenry commented Feb 7, 2021

PyBind should actually be a git sub-module. PR #400 will address this and will be removed from draft once I figure out why one of the unit tests fail.

Edit: I have removed the PR from draft so now pybind11 will hopefully be a git submodule if there are no objections. I currently use v2.6 which seems like the latest stable release. It should be easier for us to update pybind in the future now as well :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants