Skip to content

Dispose #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Muldec opened this issue Jul 30, 2018 · 2 comments
Closed

Dispose #3

Muldec opened this issue Jul 30, 2018 · 2 comments

Comments

@Muldec
Copy link

Muldec commented Jul 30, 2018

Hi !

Quick question : I can't find when the dispose method of the MovieBloc is called. Am I missing something or is it dead code as of today ?
@varunn12 varunn12 mentioned this issue Aug 10, 2018
Open
@lepinay
Copy link

lepinay commented Oct 8, 2018 •
edited
Loading

Implementation is bogus
It should use an StateFullWidget instead of an InheritedWidget for the MovieProvider and implement dispose there

See example here: https://stackoverflow.com/questions/51690230/flutter-inheritedwidget-dispose
or here https://www.didierboelens.com/2018/08/reactive-programming---streams---bloc/#there-is-only-1-constraint-accessibility-of-the-bloc

@Muldec
Copy link
Author

Muldec commented Oct 10, 2018

Thanks ! I figured it out since my original question bbut its good to have a confirmation.

@Muldec Muldec closed this as completed Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lepinay @Muldec