Skip to content

Add Imagewoof Dataset #1590

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add Imagewoof Dataset #1590

wants to merge 3 commits into from

Conversation

nouman-10
Copy link
Contributor

Add Dataset

Description

Imagewoof is a subset of 10 classes from Imagenet that aren't so easy to classify, since they're all dog breeds.
The breeds are: Australian terrier, Border terrier, Samoyed, Beagle, Shih-Tzu, English foxhound, Rhodesian ridgeback, Dingo, Golden retriever, Old English sheepdog

Checklist

  • Address all TODO's
  • Add alphabetized import to subdirectory's __init__.py
  • Run download_and_prepare successfully
  • Add checksums file
  • Properly cite in BibTeX format
  • Add passing test(s)
  • Add test data
  • Add data generation script (if applicable)
  • Lint code

@googlebot googlebot added the cla: yes Author has signed CLA label Mar 6, 2020
@Conchylicultor Conchylicultor added the dataset request Request for a new dataset to be added label Mar 6, 2020
@tfds-bot tfds-bot added the community:please_review Community - We need your help to review this PR. label Mar 8, 2020
@Eshan-Agarwal Eshan-Agarwal mentioned this pull request Mar 19, 2020
Closed
Eshan-Agarwal
Eshan-Agarwal suggested changes Mar 22, 2020
View reviewed changes
Copy link
Contributor

@Eshan-Agarwal Eshan-Agarwal left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look on these minor changes. Also ImageWoof have 320px and 160 px data size also can you please add them also

Edit : You can see Imagenette.py for reference

@tfds-bot tfds-bot added author:please_respond Author - please respond to the recent comments. and removed community:please_review Community - We need your help to review this PR. labels Mar 22, 2020
@nouman-10
Copy link
Contributor Author

@Eshan-Agarwal I have made the required changes and run pylint to ensure correct formatting. Thanks

@tfds-bot tfds-bot added community:is_reviewing This PR is being reviewed by community member. and removed author:please_respond Author - please respond to the recent comments. labels Mar 22, 2020
Eshan-Agarwal
Eshan-Agarwal reviewed Mar 22, 2020
View reviewed changes
tensorflow_datasets/image/imagewoof.py
'label': lbl_dict[image_folder]
}
count += 1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why its not showing you error for adding extra one line space after ending of code.

@tfds-bot tfds-bot added author:please_respond Author - please respond to the recent comments. and removed community:is_reviewing This PR is being reviewed by community member. labels Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Eshan-Agarwal Eshan-Agarwal Eshan-Agarwal requested changes

Assignees
No one assigned
Labels
author:please_respond Author - please respond to the recent comments. cla: yes Author has signed CLA dataset request Request for a new dataset to be added
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@nouman-10 @Eshan-Agarwal @googlebot @Conchylicultor @tfds-bot