Skip to content

fix: Take app_id_client_regex from user_pool_config (#35) #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2022

Conversation

x539
Copy link
Contributor

@x539 x539 commented Jul 8, 2022

Description

Fixes the configuration of aws_region and app_id_client_regex for cognito user pool auth.

Motivation and Context

Fixes #35

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@x539 x539 changed the title fix: take app_id_client_regex from user_pool_config (#35) Fix: take app_id_client_regex from user_pool_config (#35) Jul 8, 2022
@x539 x539 force-pushed the fix-app-id-regex branch from 41ae8ad to 192cc8f Compare July 8, 2022 14:43
@x539 x539 changed the title Fix: take app_id_client_regex from user_pool_config (#35) fix: Take app_id_client_regex from user_pool_config (#35) Jul 8, 2022
@antonbabenko antonbabenko merged commit 0e37ae7 into terraform-aws-modules:master Jul 9, 2022
antonbabenko pushed a commit that referenced this pull request Jul 9, 2022
### [1.5.2](v1.5.1...v1.5.2) (2022-07-09)

### Bug Fixes

* Take app_id_client_regex from user_pool_config ([#35](#35)) ([#38](#38)) ([0e37ae7](0e37ae7))
@antonbabenko
Copy link
Member

This PR is included in version 1.5.2 🎉

@x539 x539 deleted the fix-app-id-regex branch July 11, 2022 11:54
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

app_id_client_regex configuration for user_pool_config
3 participants