Skip to content

feat: Added support for js pipeline resolver #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 11, 2023
Merged

feat: Added support for js pipeline resolver #46

merged 8 commits into from
Mar 11, 2023

Conversation

Pranav-Dakshina
Copy link
Contributor

@Pranav-Dakshina Pranav-Dakshina commented Jan 25, 2023 •
edited by bryantbiggs
Loading

Description

  • Added support for Js pipeline resolver

Motivation and Context

Breaking Changes

  • No breaking change in this PR

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Screen Shot 2023-01-26 at 3 39 33 AM

@Pranav-Dakshina Pranav-Dakshina force-pushed the feature/support-js-resolvers branch from 7faf161 to a40127f Compare January 26, 2023 09:05
alex-roman
alex-roman approved these changes Jan 26, 2023
View reviewed changes
Copy link

@alex-roman alex-roman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

bryantbiggs
bryantbiggs reviewed Jan 26, 2023
View reviewed changes
@bryantbiggs
Copy link
Member

the code argument was added in v4.49.0 of the provider so the min supported version of the provider here will need to be set at that version

@Pranav-Dakshina Pranav-Dakshina force-pushed the feature/support-js-resolvers branch from a515404 to d30ee23 Compare January 26, 2023 21:10
@antonbabenko antonbabenko changed the title feat: Added: support for js pipeline resolver feat: Added support for js pipeline resolver Jan 27, 2023
antonbabenko
antonbabenko requested changes Jan 27, 2023
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but there are a few small suggestions to apply before we can merge it.

@Pranav-Dakshina Pranav-Dakshina force-pushed the feature/support-js-resolvers branch from b7fe745 to 02d51a9 Compare January 29, 2023 01:26
@Pranav-Dakshina
Copy link
Contributor Author

Done. I have updated the code as requested.

@antonbabenko
Copy link
Member

Examples do not work. Please fix those and let me know.

@Pranav-Dakshina
Copy link
Contributor Author

@antonbabenko 🤔 Let me check

@Pranav-Dakshina @pranav-chefman
Fixed: runtime block name
5fadb1a 
- runtime changed to block from string in the prev commit
@Pranav-Dakshina Pranav-Dakshina force-pushed the feature/support-js-resolvers branch from bbb1794 to 5fadb1a Compare February 3, 2023 12:51
@Pranav-Dakshina
Copy link
Contributor Author

@antonbabenko Should be fixed now

antonbabenko
antonbabenko reviewed Feb 3, 2023
View reviewed changes
@Pranav-Dakshina @pranav-chefman
Fixed: runtime block name
43ed06b 
- missed request template and response template
@Pranav-Dakshina Pranav-Dakshina force-pushed the feature/support-js-resolvers branch from 300ad34 to 43ed06b Compare February 3, 2023 13:43
Pranav-Dakshina
Pranav-Dakshina commented Feb 6, 2023
View reviewed changes
Copy link
Contributor Author

@Pranav-Dakshina Pranav-Dakshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@antonbabenko updated the code

@Pranav-Dakshina
Copy link
Contributor Author

@antonbabenko I have updated the code. Let me know if its good to be merged.

@GiamPy5
Copy link
Contributor

GiamPy5 commented Mar 8, 2023

I'm also in great need of this PR to be merged! Please check this out! :)

@half2me
Copy link

half2me commented Mar 11, 2023

I really need this too. I need to use APPSYNC_JS for one of my resolvers

@antonbabenko antonbabenko merged commit d660ffb into terraform-aws-modules:master Mar 11, 2023
antonbabenko pushed a commit that referenced this pull request Mar 11, 2023
@semantic-release-bot
chore(release): version 1.7.0 [skip ci]
6db4b68 
## [1.7.0](v1.6.2...v1.7.0) (2023-03-11)

### Features

* Added support for js pipeline resolver ([#46](#46)) ([d660ffb](d660ffb))
@antonbabenko
Copy link
Member

This PR is included in version 1.7.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko requested changes

@alex-roman alex-roman alex-roman approved these changes

@bryantbiggs bryantbiggs bryantbiggs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for JS resolvers About JavaScript support for AppSync Resolvers
6 participants
@Pranav-Dakshina @bryantbiggs @antonbabenko @GiamPy5 @half2me @alex-roman