fix: Replace hardcoded "aws" parition with data lookup #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcram-techcyte
changed the title
pcram-techcyte
changed the title
antonbabenko
pushed a commit
that referenced
this pull request
Mar 3, 2023
### [1.6.2](v1.6.1...v1.6.2) (2023-03-03) ### Bug Fixes * Replace hardcoded "aws" parition with data lookup ([#47](#47)) ([d6c8501](d6c8501))
|
This PR is included in version 1.6.2 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced hardcoded "aws" partition references in iam ARNs with the current partition (aws-cn, etc)
Motivation and Context
These changes are needed so the terraform apply will work in China. The current code results in
Error: putting IAM role policy service-policy: MalformedPolicyDocument: Partition "aws" is not valid for resource "arn:aws:dynamodb:cn-northwest-1...Breaking Changes
None
How Has This Been Tested?
I tested this by re-running my project that uses this module against China and it succeeded. I also re-ran it against a US based region/partition and verified it shows no changes to what we already deployed. I didn't update any of the examples since this is all behind-the-scenes and there's no effect to the user (other than it should now work in China).