Skip to content

feat: Add enhanced_metrics_config #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

srouaix
Copy link
Contributor

@srouaix srouaix commented Dec 24, 2024

Description

Add enhanced metrics configuration link to issue #67 .

Closes #67

Motivation and Context

new feature added in AWS provider terraform since 5.61 version

Breaking Changes

No Breaking Change (optional parameters)

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects

I deployed the example from main branch then the example updated with new parameters to see that there is no breaking change and that the configuration pushed on AWS and work

  • I have executed pre-commit run -a on my pull request

@srouaix srouaix changed the title feat: add enhanced_metrics_config Add enhanced_metrics_config Dec 24, 2024
@srouaix srouaix changed the title Add enhanced_metrics_config feat: Add enhanced_metrics_config Dec 24, 2024
@srouaix
Copy link
Contributor Author

srouaix commented Jan 7, 2025

@antonbabenko is it to possible to have some reviews of this PR ? It is an important feature for us.

@antonbabenko antonbabenko merged commit c18861e into terraform-aws-modules:master Jan 7, 2025
6 checks passed
@antonbabenko
Copy link
Member

Thanks @srouaix !

antonbabenko pushed a commit that referenced this pull request Jan 7, 2025
## [2.6.0](v2.5.1...v2.6.0) (2025-01-07)

### Features

* Add enhanced_metrics_config ([#68](#68)) ([c18861e](c18861e))
@antonbabenko
Copy link
Member

This PR is included in version 2.6.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 30, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add enhanced metrics configuration
2 participants