feat: Add nested_virtualization cpu_option

[xstodu07]

Description

Nested virtualization is included in the aws provider since 6.33.0, and is supported on C8i, M8i, and R8i instancecs.

Motivation and Context

• Implements: Support nested_virtualization in cpu_option #3685

Breaking Changes

How Has This Been Tested?

• I have updated at least one of the examples/* to demonstrate and validate my change(s)
• I have tested and validated these changes using one or more of the provided examples/* projects

• I have executed pre-commit run -a on my pull request

[bryantbiggs]

all of the versions throughout will need to be bumped to the min supported version for this

terraform-aws-eks/versions.tf

Line 7 in ed7f4d5

version = ">= 6.28"

[acolombier]

Tested and doesn't work unfortunately. It would seems EKS is dropping the CPU option according to this findings here. Haven't tried the AI-suggested workaround yet.

[xstodu07]

@acolombier just got it deployed also with eks-managed-node-group and it is as you say :(

[acolombier]

I can confirm it works with the self-managed module, tho you need to port the feature there as cpu_option don't have the nested_virtualization!

[acolombier]

Are you interested in also adding this feature to the self managed module @xstodu07 ? Here is the patch for it:

diff --git a/modules/self-managed-node-group/main.tf b/modules/self-managed-node-group/main.tf
index 3958fad..5c96a93 100644
--- a/modules/self-managed-node-group/main.tf
+++ b/modules/self-managed-node-group/main.tf
@@ -194,6 +194,7 @@ resource "aws_launch_template" "this" {
       amd_sev_snp      = cpu_options.value.amd_sev_snp
       core_count       = cpu_options.value.core_count
       threads_per_core = cpu_options.value.threads_per_core
+      nested_virtualization  = cpu_options.value.nested_virtualization ? "enabled" : "disabled"
     }
   }
 
diff --git a/modules/self-managed-node-group/variables.tf b/modules/self-managed-node-group/variables.tf
index 6e42508..8ffde80 100644
--- a/modules/self-managed-node-group/variables.tf
+++ b/modules/self-managed-node-group/variables.tf
@@ -227,6 +227,7 @@ variable "cpu_options" {
     amd_sev_snp      = optional(string)
     core_count       = optional(number)
     threads_per_core = optional(number)
+    nested_virtualization = optional(bool)
   })
   default = null
 }

[bryantbiggs]

if you want to add this for self-managed, we can merge this and then whenever EKS managed node group starts respecting the values it will work for MNG

[KrawczowaKris]

@bryantbiggs Would it be possible to prioritize or speed up the review/merge of this PR?

[bryantbiggs]

please fix the conflicts when you get a chance

[csantanapr]

EKS managed node group now respect this values, it was recently fixed

[bryantbiggs]

thanks @csantanapr !!!

@xstodu07 can you update and fix the conflicts when you get a chance?

[bryantbiggs]

thank you!

[antonbabenko]

This PR is included in version 21.23.0 🎉