fix: Do not expose output from build command in Docker #677
Conversation
|
Hello @antonbabenko, I'd be extremely grateful if you could find time to review this. It's a one-liner 😄 |
| @@ -49,7 +49,7 @@ data "external" "archive_prepare" { | |||
| resource "local_file" "archive_plan" { | |||
| count = var.create && var.create_package ? 1 : 0 | |||
|
|
|||
| content = data.external.archive_prepare[0].result.build_plan | |||
| content = var.build_in_docker ? sensitive(data.external.archive_prepare[0].result.build_plan) : data.external.archive_prepare[0].result.build_plan | |||
There was a problem hiding this comment.
The best solution would be to hide values ONLY if there are secrets inside. Function issensitive became available in Terraform 1.8 but this module expects Terraform 1.0.
There was a problem hiding this comment.
Indeed, my first patch was using the issensitive function, but then I checked it only appeared in 1.8. Thank you @antonbabenko!
antonbabenko
changed the title
## [7.20.3](v7.20.2...v7.20.3) (2025-05-16) ### Bug Fixes * Do not expose output from build command in Docker ([#677](#677)) ([75ee97d](75ee97d))
|
This PR is included in version 7.20.3 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
If dependencies build is performed using Docker, and additional Docker options are specified, and any of those options contain a sensitive value, the content of the archive file has also to be marked as sensitive, to avoid exposing these sensitive options in the Terraform plan. Unfortunately the
externalprovider doesn't support marking output values as sensitive, so this workaround seems like an only viable solution.Motivation and Context
Fixes #676.
Breaking Changes
None.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request