feat: Add support for restore_to_point_in_time by alacroix · Pull Request #194 · terraform-aws-modules/terraform-aws-rds-aurora

alacroix · 2021-02-19T16:32:07Z

Description

Add support for the restore_to_point_in_time block (official documentation)

Needed to add a condition on the snapshot_identifier which is incompatible with restore_to_point_in_time if defined. (see hashicorp/terraform-provider-aws#16454)

Motivation and Context

Resolves #192.

Breaking Changes

Not a breaking change but upgraded AWS Terraform provider to >= 3.19 to support this feature with all the fixes. (this one especially hashicorp/terraform-provider-aws#16465 for cross-account cloning)

How Has This Been Tested?

Forked this repo and used it on my company projects for tests environments. Successfully clone an production Aurora MySQL cluster on cross-accounts.

bryantbiggs · 2021-03-02T11:54:23Z

hi @alacroix , can you update your PR with the changes from master when you get a chance plese

alacroix · 2021-03-04T13:35:33Z

@bryantbiggs done 👍

bryantbiggs · 2021-03-06T02:52:47Z

  db_subnet_group_name                = local.db_subnet_group_name
  vpc_security_group_ids              = compact(concat(aws_security_group.this.*.id, var.vpc_security_group_ids))
-  snapshot_identifier                 = var.snapshot_identifier
+  snapshot_identifier                 = length(keys(var.restore_to_point_in_time)) == 0 ? var.snapshot_identifier : null


because of this issue hashicorp/terraform-provider-aws#16454 - lets forgo the changes on line 60 and leave it as:

Suggested change

snapshot_identifier = length(keys(var.restore_to_point_in_time)) == 0 ? var.snapshot_identifier : null

snapshot_identifier = var.snapshot_identifier

this defaults to null

bryantbiggs · 2021-03-06T02:55:30Z

+    for_each = length(keys(var.restore_to_point_in_time)) == 0 ? [] : [var.restore_to_point_in_time]
+
+    content {
+      source_cluster_identifier  = lookup(restore_to_point_in_time.value, "source_cluster_identifier", null)


this attribute is required and should be:

Suggested change

source_cluster_identifier = lookup(restore_to_point_in_time.value, "source_cluster_identifier", null)

source_cluster_identifier = restore_to_point_in_time.value.source_cluster_identifier

alacroix · 2021-03-09T09:14:04Z

@bryantbiggs thanks for the feedbacks! Done and rebased 👍

bryantbiggs · 2021-03-14T00:43:22Z

@alacroix do you know if there is a way we could test this? if so, could you create a test project for this under examples/ - something like examples/restore

rpadovani · 2021-10-12T07:00:38Z

This is nice! Can I help to move forward with this and merge this?

antonbabenko · 2021-10-12T07:29:23Z

@bryantbiggs I am not sure it is easy to make an example for this feature (it requires two runs of terraform apply). Maybe we can add a section to README.md in the root showing a code snippet and describe how a user can make a cluster restored?

@rpadovani If you can, please update the content of README and resolve conflicts in this one.

rpadovani · 2021-10-13T08:53:00Z

@rpadovani If you can, please update the content of README and resolve conflicts in this one.

@antonbabenko I am not the owner of the branch, so I cannot edit it. If you want, I can re-create this PR attributing it to the original author and improving the README.

antonbabenko · 2021-10-13T08:56:38Z

@rpadovani That's what I regularly do (if fork belongs to a person and not to the organization where I have no write access):

gh pr checkout 194
# do changes...
git commit -a -m "Something here"
git push

Read more:
https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally#modifying-an-active-pull-request-locally

rpadovani · 2021-10-13T09:49:16Z

Read more: https://docs.github.com/en/github/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally#modifying-an-active-pull-request-locally

Thanks @antonbabenko. I provided creating a new PR: #240

antonbabenko · 2021-10-13T09:53:42Z

There is no need in #240. I have just ran the commands from above and pushed 7fdf3d1

antonbabenko · 2021-10-13T09:54:28Z

v5.3.0 has been just released.

rpadovani · 2021-10-13T09:57:08Z

Thanks, @antonbabenko! Yeah, I cannot do that in this repo, thus the new PR.

I'm happy it has been merged :-) Thanks again for your time on this!

* terraform-aws-modules-master: (32 commits) chore: Giving up on releaserc config (for now) (terraform-aws-modules#257) chore(release): version 6.1.3 [skip ci] fix: Revert small useless change in main.tf (terraform-aws-modules#256) chore(release): version 6.1.2 [skip ci] fix: Small useless change in main.tf to test semantic-release (last one, I promise) (terraform-aws-modules#255) fix: Small useless change in main.tf to test semantic-release (terraform-aws-modules#254) chore: Updated .releaserc config and tf file (to trigger release) (terraform-aws-modules#253) chore: Updated .releaserc config (terraform-aws-modules#252) chore(release): version 6.1.1 [skip ci] chore: Added workflow_dispatch to allow manual releases (terraform-aws-modules#251) fix: update CI/CD process to enable auto-release workflow (terraform-aws-modules#250) Updated CHANGELOG feat: Add security group egress rule support, fix documentation links (terraform-aws-modules#249) Updated CHANGELOG chore: Updated release Makefile Updated CHANGELOG BREAKING CHANGE: update module to allow for control over individual cluster instances and latest features (terraform-aws-modules#243) chore: update CI workflow to use composite actions, update pre-commit versions (terraform-aws-modules#242) Updated CHANGELOG feat: Add support for restore_to_point_in_time (terraform-aws-modules#194) ...

github-actions · 2023-04-14T02:10:15Z

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

alacroix force-pushed the master branch from 427a74c to e2a95be Compare February 19, 2021 16:33

bryantbiggs self-requested a review March 2, 2021 11:53

alacroix force-pushed the master branch from e2a95be to 0761537 Compare March 4, 2021 13:34

bryantbiggs reviewed Mar 6, 2021

View reviewed changes

alacroix added 2 commits March 9, 2021 10:12

feat: add support for restore_to_point_in_time

2a0be0f

fix: pr feedbacks

32c3bdf

alacroix force-pushed the master branch from fdaba8e to 32c3bdf Compare March 9, 2021 09:12

Merge branch 'master' into master

8d20df5

rpadovani mentioned this pull request Oct 13, 2021

Restore point in time #240

Closed

1 task

docs: Fixed docs

7fdf3d1

antonbabenko merged commit 929f9ee into terraform-aws-modules:master Oct 13, 2021

github-actions Bot locked as resolved and limited conversation to collaborators Apr 14, 2023

	snapshot_identifier = length(keys(var.restore_to_point_in_time)) == 0 ? var.snapshot_identifier : null
	snapshot_identifier = var.snapshot_identifier

	source_cluster_identifier = lookup(restore_to_point_in_time.value, "source_cluster_identifier", null)
	source_cluster_identifier = restore_to_point_in_time.value.source_cluster_identifier

Uh oh!

Uh oh!

Conversation

alacroix commented Feb 19, 2021

Description

Motivation and Context

Breaking Changes

How Has This Been Tested?

Uh oh!

bryantbiggs commented Mar 2, 2021

Uh oh!

alacroix commented Mar 4, 2021

Uh oh!

bryantbiggs Mar 6, 2021

Choose a reason for hiding this comment

Uh oh!

bryantbiggs Mar 6, 2021

Choose a reason for hiding this comment

Uh oh!

alacroix commented Mar 9, 2021

Uh oh!

bryantbiggs commented Mar 14, 2021

Uh oh!

rpadovani commented Oct 12, 2021

Uh oh!

antonbabenko commented Oct 12, 2021

Uh oh!

rpadovani commented Oct 13, 2021

Uh oh!

antonbabenko commented Oct 13, 2021

Uh oh!

rpadovani commented Oct 13, 2021

Uh oh!

antonbabenko commented Oct 13, 2021

Uh oh!

antonbabenko commented Oct 13, 2021

Uh oh!

rpadovani commented Oct 13, 2021

Uh oh!

github-actions Bot commented Apr 14, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants