feat: add S3 import functionality which is supported for MySQL instances - #197
Merged
antonbabenko merged 3 commits intoMar 2, 2021
Merged
Conversation
Member
|
Thanks @bryantbiggs ! The only thing is that I am not sure we really need 3,4MB zip in this repo which everyone should download now even if they don't use this feature. If people will complain about it we probably need to reduce this file size to the minimum required for example. v3.7.0 has been just released. |
Member
Author
|
ya, I'm not a MySQL expert so I wasn't sure if there were things that could be trimmed from the database dump |
lsc
added a commit
to qapital/terraform-aws-rds-aurora
that referenced
this pull request
Apr 27, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
this closely mirrors what was implemented at terraform-aws-modules/terraform-aws-rds#289
Closes #126
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/s3_importmodule that was added