Skip to content

feat: Add RDS cluster activity stream - #407

Merged
bryantbiggs merged 3 commits into
terraform-aws-modules:masterfrom
magreenbaum:feat/db_cluster_activity_stream
Oct 9, 2023
Merged

feat: Add RDS cluster activity stream #407
bryantbiggs merged 3 commits into
terraform-aws-modules:masterfrom
magreenbaum:feat/db_cluster_activity_stream

Conversation

@magreenbaum

@magreenbaum magreenbaum commented Sep 24, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Closes: #404

Motivation and Context

#404

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

bryantbiggs
bryantbiggs approved these changes Oct 9, 2023
View reviewed changes

@bryantbiggs bryantbiggs left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you!

@bryantbiggs
bryantbiggs merged commit 783c686 into terraform-aws-modules:master Oct 9, 2023
antonbabenko pushed a commit that referenced this pull request Oct 9, 2023
@semantic-release-bot
chore(release): version 8.5.0 [skip ci]
66b662c 
## [8.5.0](v8.4.0...v8.5.0) (2023-10-09)

### Features

* Add RDS cluster activity stream ([#407](#407)) ([783c686](783c686))
@antonbabenko

antonbabenko commented Oct 9, 2023

Copy link
Copy Markdown
Member

This PR is included in version 8.5.0 🎉

@magreenbaum
magreenbaum deleted the feat/db_cluster_activity_stream branch October 9, 2023 13:28
@Z4ck404

Z4ck404 commented Oct 12, 2023

Copy link
Copy Markdown
Contributor

Thanks a lot @magreenbaum for the great work

Z4ck404
Z4ck404 reviewed Oct 12, 2023
View reviewed changes
Comment thread main.tf
################################################################################

resource "aws_rds_cluster_activity_stream" "this" {
count = local.create && var.create_db_cluster_activity_stream ? 1 : 0

@Z4ck404 Z4ck404 Oct 12, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a limitation on the activity stream as it's not supported by all the instances types.
works only on few of them per this doc : https://docs.aws.amazon.com/AmazonRDS/latest/AuroraUserGuide/DBActivityStreams.Overview.html

how is that taken into account ?

@bryantbiggs bryantbiggs Oct 12, 2023

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not - that's up to users

@github-actions

github-actions Bot commented Nov 12, 2023

Copy link
Copy Markdown

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@bryantbiggs bryantbiggs bryantbiggs approved these changes
+1 more reviewer
@Z4ck404 Z4ck404 Z4ck404 left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Aurora database activity stream support

4 participants

@magreenbaum @antonbabenko @Z4ck404 @bryantbiggs