feat: Add cloudwatch_log_group_tags parameter for log group tags - #472
Merged
bryantbiggs merged 1 commit intoOct 15, 2024
Merged
Conversation
bryantbiggs
reviewed
Oct 15, 2024
| } | ||
|
|
||
| variable "cloudwatch_log_group_tags" { | ||
| description = "A mapping of tags to assign to CloudWatch log groups" |
Member
There was a problem hiding this comment.
Suggested change
| description = "A mapping of tags to assign to CloudWatch log groups" | |
| description = "Additional tags for the CloudWatch log group(s)" |
Similar to `security_group_tags`, sometimes it is necessary to configure additional tags on CloudWatch log groups only.
take-five
force-pushed
the
cloudwatch-log-groups-tags
branch
from
October 15, 2024 15:27
acf0d77 to
9f622aa
Compare
cloudwatch_log_group_tags parametercloudwatch_log_group_tags parameter for log group tags
bryantbiggs
approved these changes
Oct 15, 2024
antonbabenko
pushed a commit
that referenced
this pull request
Oct 15, 2024
Member
|
This PR is included in version 9.10.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for configuring tags for CloudWatch log groups only via
cloudwatch_log_group_tagsvariable.Motivation and Context
Similar to
security_group_tags, sometimes it is necessary to configure additional tags on CloudWatch log groups only. For example, in our organization we want to mark CloudWatch log groups with RDS logs as sensitive via a tag, but we don't want to apply this tag to all resources created by this module.Breaking Changes
No
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectsI ran
terraform planfrom "examples/postgresql" folder and checked thataws_cloudwatch_log_groupresources include a custom tag:pre-commit run -aon my pull request