Skip to content

feat: Enable X-Ray tracing on Step Function if set to true in service_integrations #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 1, 2021

Conversation

nolivermke
Copy link
Contributor

Description

Check if the service_integrations variable contains a key for xray and check if its sub object is set to true. If so enable xray tracing on the step function by setting the tracing_configuration block with enabled equal to true.

Motivation and Context

Currently there is no way to enable XRay tracing with this module. Setting the service_configuration object sets up the IAM permissions but does not actually enable XRay tracing on the step function.

Breaking Changes

Possibly would cause unexpected behavior for users who expect XRay tracing to not be enabled because that is how the module currently functions.

How Has This Been Tested?

  • I have tested this using an express workflow step function that already had the XRay service_configuration value set to true. The only change to my existing TF file was the tracing_configuration value went from false to true.
      ~ tracing_configuration {
          ~ enabled = false -> true
        }
  • I also tested by removing the XRay service_configuration block and there were no changes to my current Terraform state.

@nolivermke
Copy link
Contributor Author

Hate to be that person but is there anything I can do to help get this reviewed and merged or rejected?

Our team is super grateful for this module and use it in a number of places but it would be nice to not have to manually enable x-ray tracing on our step functions.

@antonbabenko
Copy link
Member

Thank you for the PR and for the nudge! Merging this now...

My and other maintainer's focus has shifted a bit to other modules like the EKS module during the last few weeks.

@antonbabenko antonbabenko changed the title feat: Enable Xray tracing on Step Function if set to true in service_integrations feat: Enable X-Ray tracing on Step Function if set to true in service_integrations Sep 1, 2021
@antonbabenko antonbabenko merged commit 292b4b4 into terraform-aws-modules:master Sep 1, 2021
@antonbabenko
Copy link
Member

v2.4.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants