feat: Added default resources for events permissions #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Octogonapus
changed the title
Octogonapus
changed the title
|
This PR has been automatically marked as stale because it has been open 30 days |
|
This should be RTM if a maintainer has time to review it. |
antonbabenko
changed the title
|
Thanks @Octogonapus for the contribution! |
antonbabenko
pushed a commit
that referenced
this pull request
Apr 11, 2022
## [2.6.0](v2.5.2...v2.6.0) (2022-04-11) ### Features * Added default resources for events permissions ([#34](#34)) ([698e4c1](698e4c1))
|
This PR is included in version 2.6.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the relevant
default_resourcesto eacheventsblock inside theaws_service_policiessuch that users can writeevents = truefor services that require these permissions.Motivation and Context
Fixes #33.
Breaking Changes
No breaking changes have been introduced. The
default_resourcesforeventbridgecould (should) be reduced in scope, but that would be a breaking change.How Has This Been Tested?
I have tested the step functions
default_resources, as that is what I use in my projects, but I don't have a way to test the otherdefault_resourcesright now.