fix: Move default resources for events for AWS Batch service integration#44
Merged
antonbabenko merged 1 commit intoterraform-aws-modules:masterfrom Nov 2, 2022
fiffeek:user/fmikina/fix-aws-batch-default-resources
Merged
fix: Move default resources for events for AWS Batch service integration#44antonbabenko merged 1 commit intoterraform-aws-modules:masterfrom fiffeek:user/fmikina/fix-aws-batch-default-resources
antonbabenko merged 1 commit intoterraform-aws-modules:masterfrom
fiffeek:user/fmikina/fix-aws-batch-default-resources
Conversation
antonbabenko
pushed a commit
that referenced
this pull request
Nov 2, 2022
### [2.7.2](v2.7.1...v2.7.2) (2022-11-02) ### Bug Fixes * Move default resources for events for AWS Batch service integration ([#44](#44)) ([bb2186b](bb2186b))
Member
|
This PR is included in version 2.7.2 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
default_resourcesfor AWS Batch service integration (events) are not working correctly as inlocals.tfthey belong to the outer scope
batch_Syncwhereas they should belong to the nestedeventsfield.My workaround for the problem was:
Which works, but it would be nice to fix and hide the events policy as for other services it works flawlessly. Thus the MR.
Motivation / Context / Breaking Changes
No regression is being introduced as they field is not used currently (as it lies outside of the keys context either way):
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestTested with

initandplan, onmasterplan does not work correctly:After the changes everything is fine, 2 more resources as expected:

