fix: deprecate waitFor and waitForElementToBeRemoved on render

Author: timdeschryver

projects/testing-library/src/lib/models.ts

@@ -63,13 +63,19 @@ export interface RenderResult<ComponentType, WrapperType = ComponentType>
    */
   rerender: (componentProperties: Partial<ComponentType>) => void;
   /**
+   * @deprecated
+   * Usage of `waitForElementToBeRemoved` from render is deprecated, use this method directly from `@testing-library/angular`
+   *
    * @description
    * Wait for the removal of element(s) from the DOM.
    *
    * For more info see https://testing-library.com/docs/dom-testing-library/api-async#waitforelementtoberemoved
    */
   waitForElementToBeRemoved: typeof waitForElementToBeRemoved;
   /**
+   * @deprecated
+   * Usage of `waitFor` from render is deprecated, use this method directly from `@testing-library/angular`
+   *
    * @description
    * When in need to wait for any period of time you can use waitFor, to wait for your expectations to pass.
    *

projects/testing-library/src/lib/testing-library.ts

@@ -344,7 +344,15 @@ function replaceFindWithFindAndDetectChanges<T>(container: HTMLElement, original
  * Call detectChanges for all fixtures
  */
 function detectChangesForMountedFixtures() {
-  mountedFixtures.forEach(fixture => fixture.detectChanges());
+  mountedFixtures.forEach(fixture => {
+    try {
+      fixture.detectChanges();
+    } catch (err) {
+      if (!err.message.startsWith('ViewDestroyedError')) {
+        throw err;
+      }
+    }
+  });
 }
 
 /**