fix: only add container when angular attributes are removed

timdeschryver · timdeschryver · commit 65bed1b1f041 · 2020-03-24T19:30:18.000+01:00
diff --git a/projects/testing-library/src/lib/testing-library.ts b/projects/testing-library/src/lib/testing-library.ts
@@ -76,10 +76,10 @@ export async function render<SutType, WrapperType = SutType>(
     if (idAttribute && idAttribute.startsWith('root')) {
       fixture.nativeElement.removeAttribute('id');
     }
+    mountedContainers.add(fixture.nativeElement);
   }
 
   await TestBed.compileComponents();
-  mountedContainers.add(fixture.nativeElement);
 
   let isAlive = true;
   fixture.componentRef.onDestroy(() => (isAlive = false));

Original file line number	Diff line number	Diff line change
`@@ -76,10 +76,10 @@ export async function render<SutType, WrapperType = SutType>(`
`76`	`76`	`if (idAttribute && idAttribute.startsWith('root')) {`
`77`	`77`	`fixture.nativeElement.removeAttribute('id');`
`78`	`78`	`}`
	`79`	`+ mountedContainers.add(fixture.nativeElement);`
`79`	`80`	`}`
`80`	`81`
`81`	`82`	`await TestBed.compileComponents();`
`82`		`- mountedContainers.add(fixture.nativeElement);`
`83`	`83`
`84`	`84`	`let isAlive = true;`
`85`	`85`	`fixture.componentRef.onDestroy(() => (isAlive = false));`