Skip to content

Updated testing-libary.ts #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 13, 2023
Merged

Conversation

TrustNoOneElse
Copy link
Contributor

Addresses the breaking change which comes trough: angular/angular#48114
Fixes issue #350 .

Adresses the breaking change which comes trough angular/angular#48114
@@ -7,7 +7,7 @@ import {
OnChanges,
SimpleChanges,
ApplicationInitStatus,
ɵisStandalone,
isStandalone,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know if this also works with Angular v15.0 ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it does not work with Angular v15.0 since they introduced this breaking change first at v15.1.

@TrustNoOneElse
Copy link
Contributor Author

const colorControl = screen.getByRole('combobox', { name: /color/i }); in both testcases in the file src/app/examples/04-forms-with-material.spec.ts
Im not sure yet why, but i excluded the case to find out that this lines throws the error with Maximum call stack

@timdeschryver timdeschryver merged commit 072e79f into testing-library:main Jan 13, 2023
@timdeschryver
Copy link
Member

@all-contributors please add @TrustNoOneElse for code

@allcontributors
Copy link
Contributor

@timdeschryver

I've put up a pull request to add @TrustNoOneElse! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants